Fix missing download button due to theme update by un-nesting it #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the minor theme update which was (my mistake) included in #218 , the download button on the main page was silently skipped during rendering. While given nested multisections evidently have some practical use after all (in order to create a containing
divwith a unique ID around multiple elements within a section), it would be ideal to restore this capability, given this is an upstream Lektor limitation and is not needed here, the most practical near-term solution is to simply remove the vestigial nestedmultisection, since it was only there to simplify styling for the multiple download buttons this section previously contained, and no longer does.Therefore, this PR strips it out, and adjusts the other relevant bits accordingly.
Fixes #219