Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix errors when getting Matplotlib backend in the kernel (IPython console) #22231

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Jul 7, 2024

Description of Changes

  • Issue Kernel is dead message when starting Spyder #22179 was caused because the kernel was not detected as alive after it starts in slow systems (i.e. those in which the kernel takes too long to start).
  • Issue CommError upon opening existing console #22194 was a simple CommError when getting when the backend if the comm is not connected.
  • Fix test_restart_interactive_backend on Windows. That allows to check if the MatplotlibStatus widget is working fine on it.
  • Use functools.partial instead of lambda for the anonymous slots used in MatplotlibStatus. That's necessary because lambda slots prevent garbage collecting PyQt objects when self is used in them. However, functools.partial ones don't have that problem.

Issue(s) Resolved

Fixes #22194.
Fixes #22179.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@ccordoba12
Copy link
Member Author

@dalthviz, this is ready for review.

Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccordoba12 ! Checked locally and seems like things are working as expected 👍

@dalthviz dalthviz merged commit a931741 into spyder-ide:master Jul 9, 2024
14 checks passed
@ccordoba12 ccordoba12 deleted the issue-22179 branch July 9, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CommError upon opening existing console Kernel is dead message when starting Spyder
2 participants