Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Enable comms to work across different Python versions (IPython console) #22120

Merged
merged 31 commits into from
May 29, 2024
Merged

PR: Enable comms to work across different Python versions (IPython console) #22120

merged 31 commits into from
May 29, 2024

Conversation

impact27
Copy link
Contributor

@impact27 impact27 commented May 23, 2024 •
edited by ccordoba12
Loading

Description of Changes

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

Quentin Peter added 2 commits May 23, 2024 21:13
drop locals
59c7229
git subrepo clone --branch=SpyderFrameSummary --force https://github.…
0325fd6 
…com/impact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "a601d4633"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "SpyderFrameSummary"
  commit:   "a601d4633"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
@impact27 impact27 mentioned this pull request May 23, 2024
Merged
Quentin Peter added 6 commits May 23, 2024 21:39
fix import
931e6e8
Merge remote-tracking branch 'upstream/master' into SpyderFrameSummary
dd3b05e
git subrepo clone --branch=SpyderFrameSummary --force https://github.…
3b70acc 
…com/impact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "931e6e880"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "SpyderFrameSummary"
  commit:   "931e6e880"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
json dict
0756e68
Merge remote-tracking branch 'upstream/master' into SpyderFrameSummary
70f1afb
git subrepo clone --branch=SpyderFrameSummary --force https://github.…
3df0cfa 
…com/impact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "8edb4c210"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "SpyderFrameSummary"
  commit:   "8edb4c210"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
@pep8speaks
Copy link

pep8speaks commented May 25, 2024 •
edited
Loading

Hello @impact27! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 657:80: E501 line too long (82 > 79 characters)

Comment last updated at 2024-05-29 04:08:12 UTC

Quentin Peter added 4 commits May 25, 2024 19:09
git subrepo clone --branch=SpyderFrameSummary --force https://github.…
d95a601 
…com/impact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "4cc697fc8"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "SpyderFrameSummary"
  commit:   "4cc697fc8"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
git subrepo clone --branch=SpyderFrameSummary --force https://github.…
17c2ecb 
…com/impact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "4f41ea9f6"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "SpyderFrameSummary"
  commit:   "4f41ea9f6"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
Fix json typo
9c563b1
git subrepo clone --branch=SpyderFrameSummary --force https://github.…
33726fd 
…com/impact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "5382aa6c4"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "SpyderFrameSummary"
  commit:   "5382aa6c4"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
@impact27 impact27 changed the title Spyder frame summary PR: drop cloud pickle May 25, 2024
@impact27 impact27 changed the title PR: drop cloud pickle PR: drop cloudpickle May 25, 2024
Quentin Peter added 10 commits May 26, 2024 06:55
cleanup namespace
b6f7bf6
remove buffer
3b02fd2
git subrepo clone --branch=SpyderFrameSummary --force https://github.…
9ea23b6 
…com/impact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "d04b8e27d"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "SpyderFrameSummary"
  commit:   "d04b8e27d"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
git subrepo clone --branch=SpyderFrameSummary --force https://github.…
ad29c10 
…com/impact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "c3b94357e"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "SpyderFrameSummary"
  commit:   "c3b94357e"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
fix typo
c44fc09
fix test
da62775
git subrepo clone --branch=SpyderFrameSummary --force https://github.…
070441d 
…com/impact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "ab7ce7c6d"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "SpyderFrameSummary"
  commit:   "ab7ce7c6d"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
fix test
ea4787b
cloudpickle values
5eefccf
git subrepo clone --branch=SpyderFrameSummary --force https://github.…
ce2c18c 
…com/impact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "435575e27"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "SpyderFrameSummary"
  commit:   "435575e27"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
@impact27 impact27 mentioned this pull request May 26, 2024
Closed
Quentin Peter added 3 commits May 26, 2024 21:28
encoded
1962187
git subrepo clone --branch=SpyderFrameSummary --force https://github.…
6b7b1bb 
…com/impact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "7a8ad4274"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "SpyderFrameSummary"
  commit:   "7a8ad4274"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
accept bytes in comms
da2be09
Quentin Peter added 2 commits May 27, 2024 06:45
git subrepo clone --branch=SpyderFrameSummary --force https://github.…
3f0a146 
…com/impact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "872f5a325"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "SpyderFrameSummary"
  commit:   "872f5a325"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
git subrepo clone --branch=SpyderFrameSummary --force https://github.…
a698324 
…com/impact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "674f60de8"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "SpyderFrameSummary"
  commit:   "674f60de8"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
@impact27 impact27 changed the title PR: drop cloudpickle PR: Enable comms across different versions of python May 27, 2024
Quentin Peter added 2 commits May 28, 2024 07:14
frames to stack_dict
0f56e67
git subrepo clone --branch=SpyderFrameSummary --force https://github.…
ef54914 
…com/impact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "94d107e4f"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "SpyderFrameSummary"
  commit:   "94d107e4f"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
@ccordoba12 ccordoba12 added this to the v6.0beta2 milestone May 28, 2024
@ccordoba12 ccordoba12 changed the title PR: Enable comms across different versions of python PR: Enable comms across different Python versions May 28, 2024
ccordoba12
ccordoba12 reviewed May 29, 2024
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27! A few code style suggestions for you, the rest looks to me.

spyder/plugins/debugger/widgets/framesbrowser.py Outdated Show resolved Hide resolved
spyder/plugins/debugger/widgets/framesbrowser.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/comms/kernelcomm.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/comms/kernelcomm.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/comms/tests/test_comms.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/comms/tests/test_comms.py Outdated Show resolved Hide resolved
@ccordoba12 ccordoba12 changed the title PR: Enable comms across different Python versions PR: Enable comms to work across different Python versions May 29, 2024
@ccordoba12 ccordoba12 changed the title PR: Enable comms to work across different Python versions PR: Enable comms to work across different Python versions (IPython console) May 29, 2024
Quentin Peter and others added 2 commits May 29, 2024 06:05
git subrepo clone (merge) --branch=master --force https://github.com/…
4531bef 
…spyder-ide/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "cf597289f"
upstream:
  origin:   "https://github.com/spyder-ide/spyder-kernels.git"
  branch:   "master"
  commit:   "cf597289f"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
@impact27 @ccordoba12
Apply suggestions from code review
19a892e 
Co-authored-by: Carlos Cordoba <[email protected]>
ccordoba12
ccordoba12 approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @impact27!

@ccordoba12 ccordoba12 merged commit 5fbebe1 into spyder-ide:master May 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@impact27 impact27

Labels
component:Debugger component:IPython Console type:Bug
Projects
None yet
Milestone
v6.0beta2
Development

Successfully merging this pull request may close these issues.
3 participants
@impact27 @pep8speaks @ccordoba12