Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade infra, CIs and pre-commit checks & sync with website #355

Merged
merged 13 commits into from
Jan 29, 2024

Conversation

CAM-Gerlach
Copy link
Member

@CAM-Gerlach CAM-Gerlach commented Nov 4, 2023

Pull Request

Pull Request Checklist

  • Read and followed this repo's Contributing Guidelines
  • Based your PR on the latest version of the correct branch (master or 4.x)
  • Checked your writing carefully for correct English spelling, grammar, etc
  • Described your changes and the motivation for them below

Description of Changes

Counterpart to spyder-ide/website-spyder#217 and spyder-ide/lektor-icon#22

Maintenance PR to update the requirements dependencies, pre-commit hooks and action versions, and sync the hooks, config, CI and other infra with the website and docs for easier future maintenance. This also fixes a number of outstanding issues blocking PR #21 . Additionally, add Prettier to replace the deprecated Stylelint code style rules/fixers, and remove the runtime.txt file setting the Python version for Netlify that was previously required, but no longer is and will avoid an error and the need to manually fix it when Netlify updates its runtime version as in #21.

This is almost ready; just need to update the doc-specific hooks and config, the readme/contributing guide/etc. and ensure its synced with the other two, and then this should be ready to merge.

@CAM-Gerlach CAM-Gerlach force-pushed the upgrade-infra-2023-10 branch from c0de38d to 0d5d2fd Compare January 29, 2024 19:10
@CAM-Gerlach CAM-Gerlach marked this pull request as ready for review January 29, 2024 19:28
@CAM-Gerlach
Copy link
Member Author

CAM-Gerlach commented Jan 29, 2024

@ccordoba12 Had to spend a while fixing a bunch of recent docs build issues (broken links, dependencies, etc) that popped up since I last worked on this, in addition to updating the docs-specifics hooks, but this should now finally be ready to go.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @CAM-Gerlach!

@CAM-Gerlach CAM-Gerlach merged commit 678f4e9 into spyder-ide:master Jan 29, 2024
4 checks passed
@CAM-Gerlach CAM-Gerlach deleted the upgrade-infra-2023-10 branch January 29, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants