Fix typo in setup.cfg: matadata → metadata #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change to read the version is something I disagree with. I've had to hunt down big performance issues on startup for some projects that were partly due to people doing that. The title of this PR also doesn't reflect the change. |
Fixing to the typo exposed an issue building the wheel when using setup.py on a system without dateutil installed. To avoid the issue, move to a fully PEP517 compliant build approach.
No problem it has been reverted. It was done originally to handle system without |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing to the typo exposed an issue building the wheel when using
setup.py on a system without dateutil installed. To avoid the issue,
move to a fully PEP517 compliant build approach.