-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/rewrite example json generator #394
Feature/rewrite example json generator #394
Conversation
✅ Deploy Preview for springwolf-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to Springwolf. Thanks a lot for creating your first pull request. Please check out our contributors guide and feel free to join us on discord.
Hi @dipeshsingh253 , Based on a brief look this looks good, we will do a review on Friday. I started the pipeline, you probably encounter the spotless check that we configured to forbid wildcard imports. In case there are other formatting things, spotlessApply can fix most of them automatically. Great to see your effort! I am positive that we can resolve #368. |
Hey @timonback , I hope you are doing well. This is just a reminder text regarding the changes to the preview. Thanks !!! |
...core/src/main/java/io/github/stavshamir/springwolf/schemas/example/ExampleJsonGenerator.java
Outdated
Show resolved
Hide resolved
...core/src/main/java/io/github/stavshamir/springwolf/schemas/example/ExampleJsonGenerator.java
Show resolved
Hide resolved
...core/src/main/java/io/github/stavshamir/springwolf/schemas/example/ExampleJsonGenerator.java
Outdated
Show resolved
Hide resolved
...core/src/main/java/io/github/stavshamir/springwolf/schemas/example/ExampleJsonGenerator.java
Outdated
Show resolved
Hide resolved
1de7f6f
to
6fc8cbd
Compare
Hi @timonback , @sam0r040 , this time I have pushed the changes from my home setup and I actually used a script to push the changes in my home setup, and by default, I used |
Hi @dipeshsingh253 Use git status to verify what you are committing |
6fc8cbd
to
f4b015c
Compare
Hi @timonback , Thanks it worked out in the end, also I have added a .gitignore file as well in this commit please review it and if not needed I can definitely rollback it to its original state, I have just added this because this can avoid situations like this one. Thanks !!! Looking forward to this. |
Good morning, @timonback @sam0r040 , Are there any additional modifications required, or can we proceed with this PR? |
Please have look at the failing builds. I will have a look at this PR on Friday. |
They are issues related to imports. In my local Windows setup somehow IntelliJ Idea keeps removing some dependencies even when they are used. |
4c8a725
to
3d2adb8
Compare
I rebased the change on master and fixed the imports, I think this one is done. |
Thanks @sam0r040 and @timonback . This was my first open-source contribution. Thanks for all your assistance, it was really great working on this issue. |
Very welcome, thanks a lot for your contribution! |
Hi @timonback ,
I've updated ExampleJsonGenerator.java to return JsonNode in internal methods. Initially, I attempted with ObjectNode but it had limitations, allowing only key-value pair objects. JsonNode offers more flexibility with Jackson node classes.
Let me know if any modifications are needed.
Thanks!