Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rewrite example json generator #394

Conversation

dipeshsingh253
Copy link
Contributor

Hi @timonback ,

I've updated ExampleJsonGenerator.java to return JsonNode in internal methods. Initially, I attempted with ObjectNode but it had limitations, allowing only key-value pair objects. JsonNode offers more flexibility with Jackson node classes.

Let me know if any modifications are needed.

Thanks!

@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for springwolf-ui ready!

Name Link
🔨 Latest commit 3d2adb8
🔍 Latest deploy log https://app.netlify.com/sites/springwolf-ui/deploys/65326d26ddf329000853d231
😎 Deploy Preview https://deploy-preview-394--springwolf-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Springwolf. Thanks a lot for creating your first pull request. Please check out our contributors guide and feel free to join us on discord.

@timonback
Copy link
Member

Hi @dipeshsingh253 ,

Based on a brief look this looks good, we will do a review on Friday.

I started the pipeline, you probably encounter the spotless check that we configured to forbid wildcard imports. In case there are other formatting things, spotlessApply can fix most of them automatically.

Great to see your effort! I am positive that we can resolve #368.

@dipeshsingh253
Copy link
Contributor Author

Hi @dipeshsingh253 ,

Based on a brief look this looks good, we will do a review on Friday.

I started the pipeline, you probably encounter the spotless check that we configured to forbid wildcard imports. In case there are other formatting things, spotlessApply can fix most of them automatically.

Great to see your effort! I am positive that we can resolve #368.

Hey @timonback , I hope you are doing well. This is just a reminder text regarding the changes to the preview.

Thanks !!!

@dipeshsingh253 dipeshsingh253 force-pushed the feature/rewrite-exaple-json-generator branch from 1de7f6f to 6fc8cbd Compare October 14, 2023 03:18
@dipeshsingh253
Copy link
Contributor Author

Hi @timonback , @sam0r040 , this time I have pushed the changes from my home setup and I actually used a script to push the changes in my home setup, and by default, I used git add . command to add changes and now as you can see there are 70 file changes. I have searched and found that git revert can resolve this but I am not sure because I have added these changes in my last commit using git commit --amend. Any advice for me on this.?

@timonback
Copy link
Member

Hi @dipeshsingh253
Yes, git reset is probably the command you want to use. Check how other people resolved it: https://stackoverflow.com/questions/927358/how-do-i-undo-the-most-recent-local-commits-in-git#927386

Use git status to verify what you are committing

@dipeshsingh253 dipeshsingh253 force-pushed the feature/rewrite-exaple-json-generator branch from 6fc8cbd to f4b015c Compare October 14, 2023 13:25
@dipeshsingh253
Copy link
Contributor Author

Hi @timonback , Thanks it worked out in the end, also I have added a .gitignore file as well in this commit please review it and if not needed I can definitely rollback it to its original state, I have just added this because this can avoid situations like this one.

Thanks !!! Looking forward to this.

.gitignore Show resolved Hide resolved
@dipeshsingh253
Copy link
Contributor Author

Good morning, @timonback @sam0r040 ,

Are there any additional modifications required, or can we proceed with this PR?

@sam0r040
Copy link
Collaborator

Good morning, @timonback @sam0r040 ,

Are there any additional modifications required, or can we proceed with this PR?

Please have look at the failing builds. I will have a look at this PR on Friday.

@dipeshsingh253
Copy link
Contributor Author

Good morning, @timonback @sam0r040 ,
Are there any additional modifications required, or can we proceed with this PR?

Please have look at the failing builds. I will have a look at this PR on Friday.

They are issues related to imports. In my local Windows setup somehow IntelliJ Idea keeps removing some dependencies even when they are used.

@sam0r040 sam0r040 force-pushed the feature/rewrite-exaple-json-generator branch from 4c8a725 to 3d2adb8 Compare October 20, 2023 12:05
@sam0r040
Copy link
Collaborator

I rebased the change on master and fixed the imports, I think this one is done.

@sam0r040 sam0r040 merged commit fd05041 into springwolf:master Oct 20, 2023
@dipeshsingh253
Copy link
Contributor Author

Thanks @sam0r040 and @timonback . This was my first open-source contribution. Thanks for all your assistance, it was really great working on this issue.

@sam0r040
Copy link
Collaborator

Very welcome, thanks a lot for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants