GH-388: add non blocking sleeper #440
Conversation
hakimrabet
commented
May 23, 2024
hakimrabet
commented
- fix 388 (default implementation of @Backoff() should not use Thread.sleep #388)
- add non blocking sleeper
|
@hakimrabet Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@hakimrabet Thank you for signing the Contributor License Agreement! |
- fix (spring-projects#388) - add non blocking sleeper
hakimrabet
force-pushed
the
fix/add_non_blocking_sleeper
branch
from
49762a6 to
6b07318
Compare
- fix (spring-projects#388) - add non blocking sleeper
- fix (spring-projects#388) - add non blocking sleeper
| throw new BackOffInterruptedException("Thread interrupted while sleeping", e); | ||
| } | ||
| }); | ||
| future.join(); |
There was a problem hiding this comment.
I'm sorry what difference does it make against regular Thread.sleep() in the thread which calls this Sleeper?
There was a problem hiding this comment.
thanks for reading and comment my code.
when backoff execute from a scheduler and the thread that run the scheduler, going to sleep in the (sleeper.java).
the main idea of that is to release the thread that run scheduler, because the time scheduler and back off time going to Disorder the scheduler or preventing other scheduler from running.
am i right?
There was a problem hiding this comment.
Do you have a confirmation with tests that it works as you explain ?
I just believe that this join() is blocking the thread which calls it.
| throw new BackOffInterruptedException("Thread interrupted while sleeping", e); | ||
| } | ||
| }); | ||
| future.join(); |
There was a problem hiding this comment.
Do you have a confirmation with tests that it works as you explain ?
I just believe that this join() is blocking the thread which calls it.
|
i dig more about it, indeed you're right. join() block the thread as like Thread.Sleep(). |
