Fix JMS Inbound Endpoints for observation #8740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `JmsMessageDrivenEndpoint` delegates all the hard work to the `ChannelPublishingJmsMessageListener`, but missed to propagate an `ObservationRegistry` and other related options. The `JmsInboundGateway` is worse: it delegated to the `JmsMessageDrivenEndpoint` * Add `IntegrationObservation.HANDLER` observation to the `MessagingGatewaySupport.send()` operation: used by the delegate in the `ChannelPublishingJmsMessageListener` * Expose and propagate observation-related options from `JmsInboundGateway` and `JmsMessageDrivenEndpoint` * Expose `observationConvention()` option on the `MessagingGatewaySpec` and `MessageProducerSpec` **Cherry-pick to `6.1.x` & `6.0.x`**
artembilan
force-pushed
the
Fix_Delegation_in_JMS_Inbound_Endpoints
branch
from
8d2271b to
9e261ba
Compare
The parent process may still use `ObservationRegistry.NOOP` which sets `Observation.NOOP` instance into the current context and thread local
|
And Cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
JmsMessageDrivenEndpointdelegates all the hard work to theChannelPublishingJmsMessageListener, but missed to propagate anObservationRegistryand other related options.The
JmsInboundGatewayis worse: it delegated to theJmsMessageDrivenEndpointIntegrationObservation.HANDLERobservation to theMessagingGatewaySupport.send()operation: used by the delegate in theChannelPublishingJmsMessageListenerJmsInboundGatewayandJmsMessageDrivenEndpointobservationConvention()option on theMessagingGatewaySpecandMessageProducerSpecCherry-pick to
6.1.x&6.0.xRelated SO question: https://stackoverflow.com/questions/77107286/tracing-in-spring-integration-spring-boot-3-0-9