Ignore collection like attributes for query by example #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauder
added a commit
that referenced
this pull request
Jan 6, 2025
Collection valued attributes no get ignored. Before RelationalExampleMapper tried to generate predicates for these, resulting in invalid SQL. Original pull request #1969
schauder
force-pushed
the
issue/qbe-collections
branch
from
0cf19f0 to
0772cdd
Compare
schauder
added a commit
that referenced
this pull request
Jan 6, 2025
Collection valued attributes now get ignored. Before RelationalExampleMapper tried to generate predicates for these, resulting in invalid SQL. Original pull request #1969
schauder
force-pushed
the
issue/qbe-collections
branch
from
0772cdd to
89cf386
Compare
Collection valued attributes now get ignored. Before RelationalExampleMapper tried to generate predicates for these, resulting in invalid SQL. Original pull request #1969
Original pull request #1969 See spring-projects/spring-data-commons#3226
schauder
force-pushed
the
issue/qbe-collections
branch
from
89cf386 to
ce30dd6
Compare
schauder
added a commit
to spring-projects/spring-data-jpa
that referenced
this pull request
Jan 9, 2025
mp911de
reviewed
Jan 10, 2025
.../main/java/org/springframework/data/relational/repository/query/RelationalExampleMapper.java
Outdated
Show resolved
Hide resolved
mp911de
reviewed
Jan 10, 2025
...c/src/test/java/org/springframework/data/jdbc/repository/JdbcRepositoryIntegrationTests.java
Outdated
Show resolved
Hide resolved
mp911de
pushed a commit
that referenced
this pull request
Jan 13, 2025
Collection valued attributes now get ignored. Before RelationalExampleMapper tried to generate predicates for these, resulting in invalid SQL. Closes #1969
mp911de
pushed a commit
that referenced
this pull request
Jan 13, 2025
Collection valued attributes now get ignored. Before RelationalExampleMapper tried to generate predicates for these, resulting in invalid SQL. Closes #1969
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection valued attributes now get ignored.
Before RelationalExampleMapper tried to generate predicates for these, resulting in invalid SQL.