Disable in-process transport by default and add @AutoConfigureInProcessTransport annotation #88
Conversation
…ssTransport annotation
| import org.springframework.grpc.test.LocalGrpcPort; | ||
| import org.springframework.test.annotation.DirtiesContext; | ||
|
|
||
| @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT, | ||
| properties = { "spring.grpc.server.servlet.enabled=false", "spring.grpc.server.port=0" }) | ||
| @AutoConfigureInProcessTransport |
There was a problem hiding this comment.
This is wrong? I think we need it to be off in this test.
| import org.springframework.grpc.test.LocalGrpcPort; | ||
| import org.springframework.test.annotation.DirtiesContext; | ||
|
|
||
| @SpringBootTest(webEnvironment = WebEnvironment.RANDOM_PORT, properties = "spring.grpc.server.reactive.enabled=false") | ||
| @AutoConfigureInProcessTransport |
There was a problem hiding this comment.
This is not intended to be an in-process test, I think?
|
|
||
| @Target(ElementType.TYPE) | ||
| @Retention(RetentionPolicy.RUNTIME) | ||
| public @interface AutoConfigureInProcessTransport { |
There was a problem hiding this comment.
Isn't this supposed to be @ImportAutoConfiguration? Copy the annotations from one of the existing @AutoConfigure* annotations.
| import org.springframework.core.env.ConfigurableEnvironment; | ||
| import org.springframework.core.env.MapPropertySource; | ||
|
|
||
| public class InProcessTransportEnvironmentPostProcessor implements EnvironmentPostProcessor { |
There was a problem hiding this comment.
I'm not sure this is going to work. Don't we need something that is aware of the test environment? Look at the existing @AutoConfigure* annotations to see how they are implemented.
There was a problem hiding this comment.
Thanks so much for the tip. I've looked into it more, tested it, and I'd like to say. Could we create an InProcessFactory that will implement ContextCustomizerFactory? That is, make a class like ObservabilityContextCustomizerFactory
Here I have added the
AutoConfigureInProcessTransportannotation which should be set over the test where we want in-process transport to be enabled. I also added the classInProcessTransportEnvironmentPostProcessorwhich implementsEnvironmentPostProcessorand where I useAnnotationUtils.findAnnotationto check if the startup class is marked with an annotation or not. If yes, then we need to enable in-process transport and we setspring.grpc.inprocess.enabled=true. I also setmatchIfMissingto false inInProcessGrpcServerFactoryAutoConfiguration(ignored as it is by default) so that in-process will default to false.Closes #77