Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ServerBuilderCustomizer and spring.grpc.server.max-inbound-message-size property for GrpcServlet #42

Closed

Conversation

making
Copy link
Contributor

@making making commented Oct 28, 2024

Currently GrpcServlet is not customizable (e.g. Adding interceptors)
This PR supports ServerBuilderCustomizer and spring.grpc.server.max-inbound-message-size property for GrpcServlet.

…-message-size` property for `GrpcServlet`

Signed-off-by: Toshiaki Maki <[email protected]>
@making making force-pushed the servlet-customizer branch from 296812e to 52405c5 Compare October 28, 2024 12:47
@making making mentioned this pull request Oct 28, 2024
Copy link
Collaborator

@onobc onobc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @making . This servlet factory is the only one that we did not create its own GrpcServerFactory impl so this is fine to add the property mapping and customizers here for now. If we later create its own server factory we can move this logic then (e.g. like here).

A few minor suggestions / tips on the included tests but once we go through those this will be ready to merge.

BTW - thank you for adding the excellent test coverage.

Signed-off-by: Toshiaki Maki <[email protected]>
@making
Copy link
Contributor Author

making commented Oct 28, 2024

If we later create its own server factory we can move this logic then (e.g. like here).

I also initially tried to create a ServletServerFactoryPropertyMapper, but since technically there is no "ServerFactory" for GrpcServlet and there were only a few configurable items, I decided to do the mapping inline now.

Copy link
Collaborator

@onobc onobc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @making and for the contribution!

@onobc
Copy link
Collaborator

onobc commented Oct 28, 2024

Closing in favor of 7da1e80

@onobc onobc closed this Oct 28, 2024
@making making deleted the servlet-customizer branch October 29, 2024 07:47
dsyer added a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants