This repository has been archived by the owner on Apr 5, 2022. It is now read-only.
Added a field full_picture to the Post Class. #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gokul1794
changed the title
gokul1794
changed the title
|
+1 works for reads too |
|
@gokul1794 : I'm ready to merge this, but before I do, can I ask for some tests (or updates to existing tests) to verify what this PR claims to do? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #211
This will help when someone needs the original image rather than the default image provided by facebook which cannot be practically used anywhere else due to its size.
I faced this problem as I needed to fetch Posts for my app, where I needed the message and the picture, but the picture returned by the current Post object was of a size that I could not use.
Fetching full sized images using fetchConnections was slowing down the time taken to send the data back to my app as a new request needs to be made for every post.