Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish docs for New Asset Sim filter api for spot security #712

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

abharti1111
Copy link
Collaborator

@abharti1111 abharti1111 commented Jan 3, 2025

Jira Ticket

Include a link to your Jira Ticket
DOC-2682

Demo

Screen.Recording.2025-01-03.at.1.01.52.PM.mov

Checklist:

  • I have filled relevant self assessment (NodeJS, Frontend, Backend)
  • I have run ESlint on my changes and fixed all warnings and errors (NodeJS & Frontend Services)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have validated all the requirements in the Jira task were answered
  • I have all neccessary approvals for the design/mini design of this task
  • I have approved the API changes and granular permission patterns (documentation subtask) (For public services only)

@abharti1111 abharti1111 requested a review from a team as a code owner January 3, 2025 07:34
@@ -0,0 +1,34 @@
description: "The number of neighboring assets affected by the finding.\n <br>\n
\ Enter either a number or prefix it with one of the following operators.\n
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we discussed the last time, all the following operators. >> these operators:.

this needs to be done for all instances of this text in all files.

@@ -0,0 +1,34 @@
description: "The number of neighboring assets affected by the finding.\n <br>\n
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's neighboring?

\ Enter either a number or prefix it with one of the following operators.\n
\ <table>\n <tr>\n <th>Operator</th>\n <th>Notation</th>\n
\ <th>Example</th>\n </tr>\n <tr>\n <td>Equals</td>\n
\ <td>No prefix or optionally \\~eq\\~</td>\n <td>10 or \\~eq\\~10</td>\n
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for all instances of optionally in all files, change it to:
No prefix or \eq\

\ </tr>\n <tr>\n <td>Less than</td>\n <td>\\~lt\\~</td>\n
\ <td>\\~lt\\~10</td>\n </tr>\n <tr>\n <td>Less than
equals</td>\n <td>\\~lte\\~</td>\n <td>\\~lte\\~10</td>\n </tr>\n
\ <tr>\n <td>Between two ranges</td>\n <td>\\~bt\\~</td>\n <td>\\~bt\\~10,20</td>\n
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in all instances in all files, change: Between two ranges >> Between two numbers

@@ -0,0 +1,34 @@
description: "Sum of vulnerabilities, misconfigurations, threats and anomalies\n <br>\n
Copy link
Collaborator

@RachelHooley RachelHooley Jan 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sum of all vulnerabilities, misconfigurations, threats, and anomalies.
add:
, before and
all
period at end of sentence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants