Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avital-NEW/CON-22727-Ocean-AKS-Roll-External-routes-API #559

Merged

Conversation

avitalwerz
Copy link
Contributor

No description provided.

@avitalwerz avitalwerz requested a review from a team as a code owner December 6, 2023 12:17
@avitalwerz avitalwerz requested a review from yardenE December 6, 2023 12:17
summary: "Get Roll"
description: >
Get status for a roll of an Ocean cluster.
operationId: "oceanAksRollGetSingleRoll"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be GetSingleRoll?

api/spot.yaml Outdated
@@ -702,6 +702,12 @@ paths:
$ref: services/ocean/aksV2/paths/importVirtualNodeGroup.yaml
/ocean/azure/np/virtualNodeGroup/vmSizes:
$ref: services/ocean/aksV2/paths/virtualNodeGroupAllowedVmSizes.yaml
/ocean/azure/np/cluster/{oceanClusterId}/roll:
$ref: services/ocean/aksV2/paths/roll.yaml
/ocean/azure/np/cluster/{oceanClusterId}/roll{rollId}:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing /

api/spot.yaml Outdated
$ref: services/ocean/aksV2/paths/roll.yaml
/ocean/azure/np/cluster/{oceanClusterId}/roll{rollId}:
$ref: services/ocean/aksV2/paths/roll-get.yaml
/ocean/azure/np/cluster/{oceanClusterId}/roll{rollId}/stop:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing /

yardenE
yardenE previously approved these changes Dec 6, 2023
yardenE
yardenE previously approved these changes Dec 7, 2023
@avitalwerz avitalwerz merged commit de09acf into master Dec 7, 2023
2 checks passed
@avitalwerz avitalwerz deleted the Avital-NEW/CON-22727-Ocean-AKS-Roll-External-routes-API branch December 7, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants