Fix logging of sensitive information in pai.py #3310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spotify#3300 Remove logging of sensitive information in `luigi/contrib/pai.py`. * Remove the logging of the `request_json` variable in the `__init_token` method of the `PaiTask` class. * Add a new logging statement in the `__init_token` method to indicate that a token request is being made, without including sensitive information.
dlstadther
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3300
Remove logging of sensitive information in
luigi/contrib/pai.py.request_jsonvariable in the__init_tokenmethod of thePaiTaskclass.__init_tokenmethod to indicate that a token request is being made, without including sensitive information.