Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update server_test.py #3279

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Update server_test.py #3279

merged 3 commits into from
Aug 26, 2024

Conversation

eltociear
Copy link
Contributor

Description

beging -> beginning

@eltociear
Update server_test.py
60040e6 
beging -> beginning
@eltociear eltociear requested review from dlstadther and a team as code owners February 28, 2024 15:43
dlstadther
dlstadther requested changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@dlstadther dlstadther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure the comment should be begin, not beginning.

Also, appears that something CI dependencies is causing tests to fail (saw this with another PR a few days ago too). Unsure when I'll have the time to investigate further.

@dlstadther
Copy link
Collaborator

Rerunning failed tests to see if transient

@dlstadther dlstadther merged commit 4ce1a8c into spotify:master Aug 26, 2024
49 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlstadther dlstadther dlstadther approved these changes

@pablocasares pablocasares pablocasares approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eltociear @dlstadther @pablocasares