Dev/gantt no color #119
Open
Dev/gantt no color #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating license file Updating copyright headers Revert "Fixed issue for no color axis expression." This reverts commit 08f1f2bb5294c80cc32458265351df967ba2b442.
This reverts commit 62fce15.
objerke
reviewed
Sep 13, 2023
|
@objerke, there is no new loops introduced in this pull request. It is just indentation when adding the if statement to check for empty categorical expression. |
objerke
approved these changes
Sep 18, 2023
|
Did the version number of the Gantt changed? |
Yes, but only patch version to 1.0.2, see mod-manifest.json. We should perhaps make it into 1.1.0. |
|
Yes I was also thinking about a 1.1.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Gantt chart to have an empty color expression.