Fix passing arguments to yt-dlp. #2250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in yt-dlp/yt-dlp#10196, `yt_dlp.parse_options` should be used for parsing command line flags. However, as this API doesn't take in a set of configured options, the defaults handling is a little bit messier. Basically checks for any non-default values after parsing the command line flags, and skips setting them from the `defaults` dictionary. This fixes spotDL#2242.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in yt-dlp/yt-dlp#10196,
yt_dlp.parse_optionsshould be used for parsing command line flags.However, as this API doesn't take in a set of configured options, the defaults handling is a little bit messier. Basically checks for any non-default values after parsing the command line flags, and skips setting them from the
defaultsdictionary.This fixes #2242.
Title
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate)
Types of Changes
Checklist