Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Metadata to Playlist Files #2215

Merged
merged 13 commits into from
Nov 14, 2024
Merged

Add Metadata to Playlist Files #2215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
866dadd
v4.2.8
xnetcat Sep 6, 2024
f4f6ec4
Initial code commit to retain track art while downloading playlist
PranjalSurana Oct 7, 2024
3d982c4
Initial changes for adding metadata to playlist files
PranjalSurana Oct 15, 2024
03f386e
Initial commit for issue #2126
PranjalSurana Oct 15, 2024
e0fc5dd
Resolving conflicts
PranjalSurana Oct 15, 2024
0261453
Resolving conflicts
PranjalSurana Oct 15, 2024
4e6a9d4
Updated artist url in failing artist test
PranjalSurana Oct 15, 2024
9c6f50f
Reverted test change
PranjalSurana Oct 15, 2024
a037f66
Updated url in test_artist_from_string, due to failing tests
PranjalSurana Oct 20, 2024
10fc75d
Updating url in tests, which is failing
PranjalSurana Oct 20, 2024
d014bd5
Updated code and added new cli argument
PranjalSurana Oct 21, 2024
6def14e
Merge branch 'dev' into issue#2126
Silverarmor Nov 3, 2024
76b9f5a
Rmvd cli arg and reverted code
PranjalSurana Nov 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/usage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@ If you don't want config to load automatically change `load_config` option in co
"scan_for_songs": false,
"m3u": null,
"output": "{artists} - {title}.{output-ext}",
"m3u_output": "#EXTINF:{duration}, {artists} - {title}.{output-ext}",
"overwrite": "skip",
"search_query": null,
"ffmpeg": "ffmpeg",
Expand Down
2 changes: 1 addition & 1 deletion spotdl/console/save.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ async def pool_worker(song: Song):
gen_m3u_files(
songs,
m3u_file,
downloader.settings["output"],
downloader.settings["m3u_output"],
downloader.settings["format"],
downloader.settings["restrict"],
False,
Expand Down
4 changes: 2 additions & 2 deletions spotdl/console/sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def sync(
gen_m3u_files(
songs_list,
m3u_file,
downloader.settings["output"],
downloader.settings["m3u_output"],
downloader.settings["format"],
downloader.settings["restrict"],
False,
Expand Down Expand Up @@ -232,7 +232,7 @@ def sync(
gen_m3u_files(
songs_playlist,
m3u_file,
downloader.settings["output"],
downloader.settings["m3u_output"],
downloader.settings["format"],
downloader.settings["restrict"],
False,
Expand Down
2 changes: 1 addition & 1 deletion spotdl/download/downloader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ def download_multiple_songs(
gen_m3u_files(
song_list,
self.settings["m3u"],
self.settings["output"],
self.settings["m3u_output"],
self.settings["format"],
self.settings["restrict"],
False,
Expand Down
1 change: 1 addition & 0 deletions spotdl/types/options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ class DownloaderOptions(TypedDict):
scan_for_songs: bool
m3u: Optional[str]
output: str
m3u_output: str
overwrite: str
search_query: Optional[str]
ffmpeg: str
Expand Down
1 change: 1 addition & 0 deletions spotdl/utils/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,7 @@ def get_parameter(cls, key):
"scan_for_songs": False,
"m3u": None,
"output": "{artists} - {title}.{output-ext}",
"m3u_output": "#EXTINF:{duration}, {artists} - {title}.{output-ext}",
"overwrite": "skip",
"search_query": None,
"ffmpeg": "ffmpeg",
Expand Down
Loading