Add pytest-vcr-delete-on-fail

To smooth out cassette regeneration workflow -- am constantly getting
HTTP 401/429 responses, which is masking the cause of test failures.

pyproject.toml

@@ -96,6 +96,7 @@ mkdocs-section-index = "^0.3.5"
 vcrpy = "^6.0.2"
 pytest-recording = "^0.13.1"
 pytest-freezegun = "^0.4.2"
+pytest-vcr-delete-on-fail = {version = "^2.0.1", python = "^3.8.1"}
 
 [tool.poetry.scripts]
 spotdl = "spotdl:console_entry_point"

tests/console/test_entry_point.py

@@ -53,6 +53,7 @@ def test_show_version(capsys, monkeypatch, argument):
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_download_song(capsys, monkeypatch, last_vcr_recording_time, tmpdir):
     """
     This test checks if the song is downloaded correctly
@@ -84,6 +85,7 @@ def test_download_song(capsys, monkeypatch, last_vcr_recording_time, tmpdir):
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_preload_song(capsys, monkeypatch, last_vcr_recording_time, tmpdir):
     """
     This test checks if the song is preloaded correctly.

tests/providers/audio/test_youtube.py

@@ -5,6 +5,7 @@
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_yt_search():
     provider = YouTube()
 
@@ -43,6 +44,7 @@ def test_yt_search():
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_yt_get_results():
     provider = YouTube()
 

tests/providers/audio/test_ytmusic.py

@@ -5,6 +5,7 @@
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_ytm_search():
     provider = YouTubeMusic()
 
@@ -43,6 +44,7 @@ def test_ytm_search():
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_ytm_get_results():
     provider = YouTubeMusic()
 

tests/providers/lyrics/test_azlyrics.py

@@ -7,6 +7,7 @@
 
 
 # @pytest.mark.vcr()
+# @pytest.mark.vcr_delete_on_fail
 # def test_get_azlyrics_lyrics():
 #     azlyrics = AzLyrics()
 

tests/providers/lyrics/test_genius.py

@@ -7,6 +7,7 @@
 
 
 # @pytest.mark.vcr()
+# @pytest.mark.vcr_delete_on_fail
 # def test_get_genius_lyrics():
 #     genius = Genius()
 

tests/providers/lyrics/test_musixmatch.py

@@ -4,6 +4,7 @@
 
 
 # @pytest.mark.vcr()
+# @pytest.mark.vcr_delete_on_fail
 # def test_get_musixmatch_lyrics():
 #     musixmatch = MusixMatch()
 

tests/test_init.py

@@ -19,6 +19,7 @@ def setup(tmp_path, monkeypatch):
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_get_urls(monkeypatch, last_vcr_recording_time):
     """
     Tests if spotdl can be initialized correctly.
@@ -50,6 +51,7 @@ def test_get_urls(monkeypatch, last_vcr_recording_time):
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_download(setup, monkeypatch, tmpdir):
     """
     Tests if spotdl can be initialized correctly.

tests/test_matching.py

@@ -403,6 +403,7 @@
     ],
 )
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_ytmusic_matching(monkeypatch, query, expected, capsys):
     monkeypatch.setattr(SpotifyClient, "init", new_initialize)
 

tests/types/test_album.py

@@ -24,6 +24,7 @@ def test_album_wrong_init():
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_album_from_url():
     """
     Test if Album class can be initialized from url.
@@ -38,6 +39,7 @@ def test_album_from_url():
 
 
 # @pytest.mark.vcr()
+# @pytest.mark.vcr_delete_on_fail
 # def test_album_from_string():
 #     """
 #     Test if Album class can be initialized from string.
@@ -52,6 +54,7 @@ def test_album_from_url():
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_album_length():
     """
     Tests if Album.length works correctly.

tests/types/test_artist.py

@@ -42,6 +42,7 @@ def test_artist_wrong_init():
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_artist_from_url():
     """
     Test if Artist class can be initialized from url.
@@ -56,6 +57,7 @@ def test_artist_from_url():
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_artist_from_string():
     """
     Test if Artist class can be initialized from string.

tests/types/test_playlist.py

@@ -42,6 +42,7 @@ def test_playlist_wrong_initget_results():
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_playlist_from_url():
     """
     Tests if Playlist.from_url() works correctly.
@@ -58,6 +59,7 @@ def test_playlist_from_url():
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_playlist_from_string():
     """
     Test if Playlist class can be initialized from string.
@@ -71,6 +73,7 @@ def test_playlist_from_string():
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_playlist_length():
     """
     Tests if Playlist.length works correctly.

tests/types/test_song.py

@@ -78,6 +78,7 @@ def test_song_wrong_init():
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_song_from_url():
     """
     Tests if Song.from_url() works correctly.
@@ -109,6 +110,7 @@ def test_song_from_url():
 
 
 # @pytest.mark.vcr()
+# @pytest.mark.vcr_delete_on_fail
 # def test_song_from_search_term():
 #     """
 #     Tests if Song.from_search_term() works correctly.

tests/utils/test_ffmpeg.py

@@ -116,6 +116,7 @@ def test_download_ffmpeg(monkeypatch, tmpdir):
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_convert(tmpdir, monkeypatch, last_vcr_recording_time):
     """
     Test convert function.

tests/utils/test_github.py

@@ -11,19 +11,22 @@
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_get_status():
     status = get_status("master", "dev", "spotdl/spotify-downloader")
 
     assert None not in status
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_get_status_fail():
     with pytest.raises(RuntimeError):
         get_status("master", "dev", "spotdl/spotify-downloader-fail")
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_check_for_updates(monkeypatch):
     monkeypatch.setattr(_version, "__version__", "3.9.4")
     message = check_for_updates("spotdl/spotify-downloader")
@@ -32,20 +35,23 @@ def test_check_for_updates(monkeypatch):
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_check_for_updates_fail(monkeypatch):
     monkeypatch.setattr(_version, "__version__", "3.9.4")
     with pytest.raises(RuntimeError):
         check_for_updates("spotdl/spotify-downloader-fail")
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_create_github_url():
     url = create_github_url(WEB_APP_URL)
 
     assert url == "https://api.github.com/repos/spotdl/web-ui/contents/dist?ref=master"
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_download_github_dir(tmpdir, monkeypatch):
     monkeypatch.chdir(tmpdir)
     download_github_dir(WEB_APP_URL, False)

tests/utils/test_m3u.py

@@ -7,6 +7,7 @@
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_create_m3u_content():
     playlist = Playlist.from_url(PLAYLIST)
     content = create_m3u_content(
@@ -19,6 +20,7 @@ def test_create_m3u_content():
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_create_m3u_file(tmpdir, monkeypatch):
     monkeypatch.chdir(tmpdir)
     playlist = Playlist.from_url(PLAYLIST)

tests/utils/test_metadata.py

@@ -22,6 +22,7 @@
     ],
 )
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_embed_metadata(tmpdir, monkeypatch, last_vcr_recording_time,
                         output_format):
     """

tests/utils/test_search.py

@@ -19,6 +19,7 @@
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_parse_song():
     songs = parse_query(SONG)
 
@@ -28,6 +29,7 @@ def test_parse_song():
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_parse_album():
     songs = parse_query(ALBUM)
 
@@ -36,6 +38,7 @@ def test_parse_album():
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_parse_yt_link():
     songs = parse_query(YT)
 
@@ -45,33 +48,38 @@ def test_parse_yt_link():
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_parse_artist():
     songs = parse_query(ARTIST)
 
     assert len(songs) > 1
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_parse_album_search():
     songs = parse_query(ALBUM_SEARCH)
 
     assert len(songs) > 1
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_parse_saved():
     with pytest.raises(SavedError):
         parse_query(SAVED)
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_parse_query():
     songs = parse_query(QUERY)
 
     assert len(songs) > 1
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_get_search_results():
     results = get_search_results("test")
     assert len(results) > 1
@@ -87,6 +95,7 @@ def test_create_empty_song():
 
 
 @pytest.mark.vcr()
+@pytest.mark.vcr_delete_on_fail
 def test_get_simple_songs():
     songs = get_simple_songs(QUERY)
     assert len(songs) > 1