Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor prepare #1127

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix: refactor prepare #1127

merged 1 commit into from
Nov 18, 2024

Conversation

ajasnosz
Copy link
Collaborator

@ajasnosz ajasnosz commented Nov 14, 2024

Description

Refactor of prepare method.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Refactor/improvement

How Has This Been Tested?

manual, integration, unit

Checklist

  • My commit message is conventional
  • I have run pre-commit on all files before creating the PR
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@ikheifets-splunk
Copy link
Contributor

@ajasnosz it's marked as draft, but I assigned as reviewer. It it ready for review?

@ajasnosz ajasnosz marked this pull request as ready for review November 18, 2024 08:56
@ajasnosz ajasnosz merged commit d967e58 into develop Nov 18, 2024
12 checks passed
@ajasnosz ajasnosz deleted the fix/refactor-prepare branch November 18, 2024 14:37
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2024
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 1.12.1-beta.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants