Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log duplication when using wildcards in log path #729

Closed
wants to merge 1 commit into from

Conversation

vzabawski
Copy link
Contributor

Proposed changes

Automatically add follow_inodes true Fluentd parameter if path contains wildcards.
From fluentd documentation:

You should set true when you use * or strftime format in path.

Resolves: #728

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I have read the CLA
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@vzabawski
Copy link
Contributor Author

Not really sure if it's a bugfix or improvement. Such functionality was never said to be supported, so I guess it's more like an improvement rather than a bugfix.

@hvaghani221
Copy link
Contributor

Hey @vzabawski, thanks for the contribution. Should we add the same config for the container logs as well? I am not sure if we can perform log rotation for container logs.

@vzabawski
Copy link
Contributor Author

To be honest, I'm not sure if this PR actually means something. I was testing this updated chart and the issue is still reproducible. I saw some issues created in fluentd repo related to this behavior, but according to the issue, it was addressed in fluentd 1.14.4. At the same time, the issue is still being reproduced with fluentd 1.14.4, so I'm testing. I guess this PR should be placed on hold for now. I'll update it once I get some results.

@hvaghani221
Copy link
Contributor

Closing the PR for now. Feel free to reopen when it is ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid duplicated events on log file rename
2 participants