Merge upstream #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches to the newer label based approach used in eg: https://github.com/heroku/buildpacks-python/blob/main/.github/workflows/check_changelog.yml
* Add `bin/report` script to capture buildpack metadata [W-15039947](https://gus.lightning.force.com/lightning/r/a07EE00001k7v4BYAQ/view)
Includes: - heroku#110
* Fix variable quoting throughout Guards against glob expansion from user input, and works with spaces etc in any path names. Double square brackets do not technically need quoting, but doing it for consistency, as the lines have been touched anyway. Variable assignments, on the other hand, do not require quoting, but I did not remove existing quotes to aid future 'git blame's. * Fix .deb globbing Iterating over 'ls' output breaks with spaces in path names * Use nul byte separators with find/xargs Guards against spaces etc in path/file names
…le line (heroku#112) * Handle when multiple packages are declared on a single line.
* Update CHANGELOG.md --------- Co-authored-by: Rune Soerensen <[email protected]>
Now:
- If the stack version file is missing, we don't assume the cached files
belong to the current stack (since that could cause breakage), and
instead invalidate the cache. (The cache actually offers little benefit
in practice for this buildpack, so invalidating is cheap.)
- The whole `${CACHE_DIR}/apt` directory is removed rather than
only the `${CACHE_DIR}/apt/cache` directory. This ensures the APT
indexes and other files from old stack versions are cleaned up too.
- Some build output logs have been adjusted to be more accurate.
- A test has been added for cache re-use, since it wasn't previously
tested.
These papercuts were noticed whilst working on:
heroku/heroku-buildpack-chrome-for-testing#21
Since this repo uses GitHub Actions for CI instead.
With a `[publish.Ignore]` table, to exclude unnecessary files from the buildpack archive published to the buildpack registry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.