Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding flag sets in DataInspector view. #257

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Adding flag sets in DataInspector view. #257

merged 4 commits into from
Jan 11, 2024

Conversation

sanzmauro
Copy link
Contributor

Split Synchronizer

What did you accomplish?

Screenshot 2023-12-13 at 15 27 14

@sanzmauro sanzmauro self-assigned this Dec 15, 2023
@sanzmauro sanzmauro requested a review from a team as a code owner December 15, 2023 19:35
@sonarqube-pull-requests SonarQube Pull Requests
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

nmayorsplit
nmayorsplit previously approved these changes Dec 20, 2023
View reviewed changes
Copy link

@nmayorsplit nmayorsplit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave a minor change to do.

splitio/admin/views/dashboard/main.go Show resolved Hide resolved
@sanzmauro sanzmauro dismissed stale reviews from nmayorsplit and EmilianoSanchez via 8b21e4e January 8, 2024 15:33
@sonarqube-pull-requests SonarQube Pull Requests
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sanzmauro sanzmauro changed the base branch from master to release-5.6.0 January 11, 2024 19:03
@sanzmauro sanzmauro merged commit 5e0177b into release-5.6.0 Jan 11, 2024
6 checks passed
@sanzmauro sanzmauro deleted the SDKS-7840 branch January 11, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilianoSanchez EmilianoSanchez EmilianoSanchez approved these changes

@nmayorsplit nmayorsplit Awaiting requested review from nmayorsplit

Assignees

@sanzmauro sanzmauro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanzmauro @EmilianoSanchez @nmayorsplit