Skip to content

Commit

Permalink
pr feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
sanzmauro committed Jan 11, 2024
1 parent fd3605d commit abdf46b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
1 change: 0 additions & 1 deletion splitio/producer/conf/sections.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ type Redis struct {
TLSSkipNameValidation bool `json:"tlsSkipNameValidation" s-cli:"redis-tls-skip-name-validation" s-def:"false" s-desc:"Blindly accept server's public key."`
TLSClientCertificate string `json:"tlsClientCertificate" s-cli:"redis-tls-client-certificate" s-def:"" s-desc:"Client certificate signed by a known CA"`
TLSClientKey string `json:"tlsClientKey" s-cli:"redis-tls-client-key" s-def:"" s-desc:"Client private key matching the certificate."`
ScanCount int `json:"scanCount" s-cli:"redis-scan-count" s-def:"10" s-desc:"It is the number of keys to search through at a time per cursor iteration, we use it to read feature flag names and flag set names."`
}

// Healthcheck configuration options
Expand Down
3 changes: 2 additions & 1 deletion splitio/producer/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import (
const (
impressionsCountPeriodTaskInMemory = 1800 // 30 min
impressionObserverSize = 500
ScanCount = 10
)

func parseTLSConfig(opt *conf.Redis) (*tls.Config, error) {
Expand Down Expand Up @@ -99,7 +100,7 @@ func parseRedisOptions(cfg *conf.Redis) (*config.RedisConfig, error) {
WriteTimeout: cfg.WriteTimeout,
PoolSize: cfg.PoolSize,
TLSConfig: tlsCfg,
ScanCount: cfg.ScanCount,
ScanCount: ScanCount,
}

if cfg.SentinelReplication {
Expand Down

0 comments on commit abdf46b

Please sign in to comment.