fixing splitChanges endpoint

splitio · Nov 29, 2024 · 1433b8f · 1433b8f
1 parent 86d6ad3
commit 1433b8f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/splitio/proxy/conf/sections.go b/splitio/proxy/conf/sections.go
@@ -35,6 +35,7 @@ func (m *Main) BuildAdvancedConfig() *cconf.AdvancedConfig {
 	tmp.SegmentsRefreshRate = int(m.Sync.SegmentRefreshRateMs / 1000)
 	tmp.LargeSegment.LazyLoad = m.Sync.Advanced.LargeSegmentLazyLoad
 	tmp.LargeSegment.RefreshRate = int(m.Sync.LargeSegmentRefreshRateMs / 1000)
+	tmp.LargeSegment.Version = m.LargeSegmentVersion
 	return tmp
 }
 

diff --git a/splitio/proxy/controllers/sdk.go b/splitio/proxy/controllers/sdk.go
@@ -121,10 +121,14 @@ func (c *SdkServerController) SplitChanges(ctx *gin.Context) {
 		return
 	}
 
-	spec, _ := ctx.GetQuery("s")
-	if spec != specs.FLAG_V1_1 {
-		spec = specs.FLAG_V1_0
+	sParam, _ := ctx.GetQuery("s")
+	spec, err := specs.ParseAndValidate(sParam)
+	if err != nil {
+		c.logger.Error(fmt.Sprintf("error getting split changes: %s.", err))
+		ctx.JSON(http.StatusBadRequest, gin.H{"code": 400, "message": err.Error()})
+		return
 	}
+
 	splits.Splits = c.patchUnsupportedMatchers(splits.Splits, spec)
 
 	ctx.JSON(http.StatusOK, splits)