Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rails-7.1.3.2 #198

Merged
merged 7 commits into from
Apr 22, 2024
Merged

Use rails-7.1.3.2 #198

merged 7 commits into from
Apr 22, 2024

Conversation

jiikko
Copy link
Member

@jiikko jiikko commented Apr 22, 2024

No description provided.

@jiikko jiikko changed the title Use rails- 7.1.3.2 Use rails-7.1.3.2 Apr 22, 2024
Copy link

github-actions bot commented Apr 22, 2024

https://pr-198---pbm-cloud-7hrjn5ej3q-an.a.run.app/ がデプロイされました

subject
expect(response.response_code).to eq(500)
end
it { expect { subject }.not_to change { user.devices.count } }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [rubocop] <Lint/AmbiguousBlockAssociation> reported by reviewdog 🐶
Parenthesize the param change { user.devices.count } to make sure that the block will be associated with the change method call.

Suggested change
it { expect { subject }.not_to change { user.devices.count } }
it { expect { subject }.not_to( change { user.devices.count } }

@jiikko jiikko force-pushed the upgrade-rails branch 2 times, most recently from ca37006 to ab363a4 Compare April 22, 2024 13:10
…a2_password requires either TCP with TLS or a unix socket: TRILOGY_UNSUPPORTED (ActiveRecord::ConnectionNotEstablished)
@jiikko jiikko merged commit 4efe57e into master Apr 22, 2024
9 checks passed
@jiikko jiikko deleted the upgrade-rails branch April 22, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant