WIP: Typelib loading #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I dropped the ball on this. Sorry. Given the discussion occurring in #96 , is this still good to go? |
|
This is somewhat adjacent to #96, but can not solve it completely. I am not entirely sure, but I believe this solves a slightly different issue, wherein loading one typelib and creating all its definitions can leave you with an incomplete view on "the world" as defined through typelib dependencies. |
spk121
force-pushed
the
master
branch
6 times, most recently
from
3c24848 to
366f9f9
Compare
LordYuuma
commented
Jun 30, 2021
| ((module? module) module) | ||
| ((list? module) | ||
| (let ((m (resolve-module module))) | ||
| (set-module-duplicates-handlers! m %gig-duplicate-handlers) |
There was a problem hiding this comment.
Slight oversight, we should first check whether m is a fresh module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the immediate dependencies of a typelib to the module-uses of the module generated from it and installs a duplicate handler, which reports duplicates as Guile-GI warnings. We should try to resolve those at some point, and especially find out why our generics sometimes won't merge.