chore(upgrades): Update OS to latest supported releases #687
Conversation
| resources.filter { | ||
| subject.apply(it, emptyList()) == null | ||
| }.let { filteredResources -> | ||
| filteredResources.size shouldMatch equalTo(1) |
There was a problem hiding this comment.
I see this failed with:
AmazonTagExclusionPolicyTest > should handle high precision date times() FAILED
java.lang.AssertionError: expected: a value that is equal to 1
but was: 2
at com.natpryce.hamkrest.assertion.Assertion.that(assert.kt:17)
at com.natpryce.hamkrest.assertion.Assertion.that$default(assert.kt:14)
at com.natpryce.hamkrest.assertion.Assert.assertThat(assert.kt:45)
at com.natpryce.hamkrest.should.Should.shouldMatch(should.kt:15)
at com.netflix.spinnaker.swabbie.aws.exclusions.AmazonTagExclusionPolicyTest.should handle high precision date times(AmazonTagExclusionPolicyTest.kt:160)
but it doesn't seem correct to totally remove the assertions. Do you know why it failed?
There was a problem hiding this comment.
Yeah that's because i copied & pasted the above test & realized today that test seemed to depend upon the date comparison. AKA the test was just a copy/paste to test serialization of the date string but I included all the OTHER logic without really looking at it so i stripped it all out JUST for the serialization aspects.
There was a problem hiding this comment.
But this test needs at least one assertion, right?
There was a problem hiding this comment.
Technically no ;) All we're doing is testing the serialization - assertions are NOT technically required particularly if an exception is expected on an operation. E.g. this is... almost just testing the constructor behavior passes without fialures. I can add an assertion if we really want.
No description provided.