feat(swabbie): Dockerize Swabbie #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,8 @@ | |||
| FROM ubuntu:jammy | |||
| RUN apt-get update && apt-get install -y \ | |||
| openjdk-11-jdk \ | |||
There was a problem hiding this comment.
Wondering if shouldn't run on 17 vs. 11 kinda thing for builds now. The target on the gradle plugin should still compile to 11... but can use the 17 JDK for this.
There was a problem hiding this comment.
NOTE: This is how other projects work, so separate PR for that.
Halyard don't support Swabbie
|
Thanks @jasonmcintosh! Not sure if any credentials or other env variables needs to be added to the repo, but hopefully everything is inherited from the org. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.