Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Add another date format to the date parser #667

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

jervi
Copy link
Contributor

@jervi jervi commented May 29, 2024

Swabbie started failing when parsing AMI image timestamp. Adding another pattern to the list of supported formats fixed the issue.

Swabbie started failing when parsing AMI image timestamp. Adding another pattern to the list of supported formats fixed the issue.
@jervi jervi requested a review from jeyrschabu as a code owner May 29, 2024 09:16
@jasonmcintosh
Copy link
Member

I'd NORMALLY prefer tests :P BUT given the state of this project... and there aren't tests already... ok ;)

@jasonmcintosh jasonmcintosh added the ready to merge Reviewed and ready for merge label Jun 10, 2024
@mergify mergify bot added the auto merged label Jun 10, 2024
@mergify mergify bot merged commit 4cad413 into spinnaker:master Jun 10, 2024
4 checks passed
@jervi jervi deleted the fix_date_parsing branch June 10, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged ready to merge Reviewed and ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants