fix(config): Exception in fresh development environment (LocalGit) #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgogerly
reviewed
Jun 20, 2023
| baseUrl: http://localhost:7003 | ||
| front50: | ||
| baseUrl: http://localhost:8080 | ||
| igor: |
There was a problem hiding this comment.
I'd suggest defaulting igor to enabled: false as it isn't a core service.
There was a problem hiding this comment.
There's NORMALLY a default spinnaker.yml file that should set all of these appropriately. I know that's deployed via halyard/operator. I though local dev had it someplace too, or at least, had localhost as the defaults on some of these.
There was a problem hiding this comment.
I thought these files were included someplace else and so MAY not need to be set this way kinda thing...
There was a problem hiding this comment.
In the gate, only the fiat baseUrl was missing:
https://github.com/spinnaker/gate/pull/1671/files
gustavotemple
force-pushed
the
issue-services-url
branch
from
f9781c9
to
1cb7cf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After following the guide below in a fresh development environment (LocalGit):
https://spinnaker.io/docs/community/contributing/code/developer-guides/dev-env/getting-set-up/
I got:
When I run
./gradlew run