-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add segmentations from William Sirois #172
base: master
Are you sure you want to change the base?
Conversation
I added to the branch the spinal cord canal seg under derivatives/labels, I am not sure that it worked, @mguaypaq can you check? |
It looks like this is what happened:
But:
@sandrinebedard is this what you wanted? |
Nope hahaha, just realized a script I was running was modifying the files... sorry, we should remove those changes |
Ok, I can remove the extra modifications. Do we also need to create and/or update any JSON sidecars with the provenance of the data? |
Abel just created them yesterday, I will push them today! |
I don't think these are the right JSON sidecars; they describe the 267 images mentioned at the end of ivadomed/model-canal-seg#7, but not the 188 images mentioned at the start (which are the ones in this PR). We probably need at least 4 different JSON files:
That's if we want the 188 images used as ground truth for the training. Alternatively, if we want the 267 images produced by the final model, we could upload them instead? Or, if we're not sure of the origin, we should say that in the JSON files. |
The corresponding image files are unmodified, so their provenance shouldn't be overwritten.
It's unclear which model was actually used to generate these images.
Now that these files have been integrated under derivatives/labels/, we don't need to keep the original non-BIDS names.
Ok, here's what I did:
@sandrinebedard Does this look ok to merge? |
These are the files provided by William Sirois at the end of his GBM3100 internship. Todo:
derivatives/
subfolder they should go into.While uploading the files, I noticed that most of them are new, but a few of them are exact duplicates of already existing files in the repository.