-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for spinal rootlets segmentation #98
Conversation
You can also add rootlets into this list: https://github.com/spinalcordtoolbox/manual-correction/blob/main/README.md?plain=1#L5-L12 |
I added some unit tests for recently implemented
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @KaterinaKrejci231054! I tested the PR using the following command, and it worked perfectly!
python manual_correction.py -path-img ~/data/results/philadelphia-pediatric/philadelphia-pediatric_2024-06-26/data_processed -path-label ~/data/results/philadelphia-pediatric/philadelphia-pediatric_2024-06-26/derivatives/labels -change-orient RPI -path-out ~/data/results/philadelphia-pediatric/philadelphia-pediatric_2024-06-26/derivatives_corr/labels -config ~/data/results/philadelphia-pediatric/philadelphia-pediatric_2024-06-26/three_subjects_to_correct.json -fsleyes-cm jet_matplotlib
I'm pre-approving the PR.
Can you please address this comment?
I'll address the failing CI. Then, we can merge!
Hey, @joshuacwnewton! I added SCT installation into the manual_correction CI in d58dfee and 56b375f, but CI still struggles to locate ...
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/subprocess.py:1720: FileNotFoundError
=========================== short test summary info ============================
FAILED tests/test_utils.py::test_get_orientation - FileNotFoundError: [Errno 2] No such file or directory: 'sct_image'
FAILED tests/test_utils.py::test_change_orientation - FileNotFoundError: [Errno 2] No such file or directory: 'sct_image'
========================= 2 failed, 9 passed in 0.40s ========================== Do you have any ideas on how to solve this? |
Thanks for the ping! I have a bit of a backlog to get through since coming back from the conference I was attending, but I'm very happy to take a look at this soon. :) |
@KaterinaKrejci231054, thanks for this PR, and @joshuacwnewton, thanks for fixing the CI! |
This draft PR adds an option to correct rootlets segmentation.
Resolves: #56