Tornjak UI Refactoring V2 #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have refactored the main user interface for Tornjak after addressing the issue of windows new line. Please test for functionality. Signed-off-by: Kai Chen <[email protected]>
Added troubleshooting instructions for the issue where modifying a single line marks the entire file as changed on a Windows machine. Signed-off-by: Kai Chen <[email protected]>
EdgarAllan-Bro
requested review from
lumjjb,
mrsabath,
mamy-CS and
maia-iyer
as code owners
mamy-CS
added
enhancement
Allow dashboard title to be on one line, health check properly positioned, remove unused tooltip import Signed-off-by: Kai Chen <[email protected]>
mamy-CS
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
/lgtm thank you for this great contribution @EdgarAllan-Bro Ui looks so much better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have refactored the main user interface for Tornjak. Please test for functionality.