Fix #179

spicywebau · Jan 25, 2019 · 3b5ba1f · 3b5ba1f
1 parent 4589660
commit 3b5ba1f
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 2.1.7 - 2019-01-25
+### Fixed
+- Fixed issue where Neo blocks would not appear on duplicated entries
+
 ## 2.1.6 - 2019-01-24
 ### Fixed
 - Fixed error when pasting or cloning blocks on single-site Craft installations

diff --git a/composer.json b/composer.json
@@ -1,7 +1,7 @@
 {
   "name": "spicyweb/craft-neo",
   "description": "A Matrix-like field type that uses existing fields",
-  "version": "2.1.6",
+  "version": "2.1.7",
   "type": "craft-plugin",
   "keywords": [
     "cms",

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "craft-neo",
-  "version": "2.1.6",
+  "version": "2.1.7",
   "description": "A Matrix-like field type that uses existing fields",
   "main": "webpack.config.js",
   "scripts": {

diff --git a/src/services/Fields.php b/src/services/Fields.php
@@ -226,7 +226,7 @@ public function saveValue(Field $field, ElementInterface $owner, bool $isNew)
 
 				$blockIds = [];
 
-				foreach ($blocks as $block)
+				foreach ($blocks as &$block)
 				{
 					if ($duplicateBlocks)
 					{
@@ -251,6 +251,8 @@ public function saveValue(Field $field, ElementInterface $owner, bool $isNew)
 					$blockIds[] = $block->id;
 				}
 
+				unset($block);
+
 				// Now find any blocks that need to be deleted
 				// The blocks need to be returned in reverse order, as trying to delete them in regular order can
 				// cause a level-related SQL error