Convert string slice to string using strings.Join(s, ","). #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
In this PR, I added support to convert string slice to string using
strings.Join(s, ",")
.I was experimenting yesterday with some code based on
spf13/viper
and was surprised to get an empty string as result of callingGetString()
on a config key I know was a string slice.Moreover, I did not get any error message, as
GetString()
did not return one:https://github.com/spf13/viper/blob/551e8939be1e18c45accb6d144e6c19e46ee24e1/viper.go#L785-L787
As I think this code may be useful for other people, I decided to open a PR.
Please let me know what you think about it.
Best regards.