State refactor #407
Open
State refactor #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… save/load save state saving/loading from/to slot 5 which is not guaranteed to be the main after online session
Mr-Auto
commented
Dec 30, 2024
…move `read_prng` and some `get_frame_count` from `State`, remove `get_frame_count` from rpc
…quidOutOfBoundsBugfix`
…s`, `set_pause`, `get_offset` from the `State`
Mr-Auto
commented
Jan 4, 2025
| @@ -18,6 +18,7 @@ Illumination* create_illumination(Vec2 pos, Color col, LIGHT_TYPE type, float si | |||
|
|
|||
| typedef Illumination* create_illumination_func(custom_vector<Illumination*>*, Vec2*, Color, LIGHT_TYPE, float, uint8_t light_flags, int32_t uid, uint8_t layer); | |||
| static create_illumination_func* cif = (create_illumination_func*)(offset); | |||
| // enum_to_layer here does not use offset which you could argue should be used, since this function is comparable with spawn type function | |||
There was a problem hiding this comment.
Should i change this, or you recon this has been in API for too long like this and potentially breaking change for some mods is not worth it?
…o `remove_liquid_oob`, move `API::init` to the end of state.cpp
…nctions in state.hpp to namespace
…d` to `StateMemory::get_entity`, move the rest of the function to the `API` namespace
Mr-Auto
commented
Jan 6, 2025
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StatetoStateMemoryor standaloneStatestruct