Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

top -> xvi-ee #20

Merged
merged 2 commits into from
Jun 17, 2024
Merged

top -> xvi-ee #20

merged 2 commits into from
Jun 17, 2024

Conversation

speleo3
Copy link
Owner

@speleo3 speleo3 commented Jun 13, 2024

PocketTopo -> XVI extended elevation dump with topreader.py --dump xvi-ee

Note: Splay direction is not yet handled, they are always placed in forward direction skipped for now.

Closes #14

@speleo3
Copy link
Owner Author

speleo3 commented Jun 13, 2024

@MFeldmaier can you please review?

speleo3 added 2 commits June 15, 2024 07:56
PocketTopo -> XVI extended elevation dump

Closes #14
@MFeldmaier
Copy link
Collaborator

Looks good.

One minor remark.

When I call the -h option on topreader.py

fem@rechner:~/Hoefo/inkscape-speleo/extensions$ ./topreader.py -h
usage: topreader.py [-h] [--dump {json,svg,svx,th,th2,tro,xvi,xvi-ee,th2-xvi}] [--view {aven,inkscape}] [--surveyname SURVEYNAME] [--prefixadd PREFIXADD] [--prefixstrip PREFIXSTRIP] [--no-avg] [--do-sep] FILENAME [FILENAME ...]

positional arguments:
  FILENAME              one or more .top files

options:
  -h, --help            show this help message and exit
  --dump {json,svg,svx,th,th2,tro,xvi,xvi-ee,th2-xvi}
                        dump file to stdout
  --view {aven,inkscape}
                        open viewer application
  --surveyname SURVEYNAME
                        survey name for survex dump
  --prefixadd PREFIXADD
                        station name prefix to add
  --prefixstrip PREFIXSTRIP
                        station name prefix to strip
  --no-avg              don't average repeated legs
  --do-sep              separate legs from splays

the explanation is rather short.
Could you improve the help menu and add some explanation to the individual options.

I especially found the difference between xvi and xvi-ee not self-explaining.
Maybe rename the first to xvi-plan?

Anyway, just a suggestion ;-)

Copy link
Collaborator

@MFeldmaier MFeldmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@speleo3
Copy link
Owner Author

speleo3 commented Jun 17, 2024

Thanks @MFeldmaier, I moved your feedback to a new ticket: #21

@speleo3 speleo3 merged commit 16fc189 into master Jun 17, 2024
2 checks passed
@speleo3 speleo3 deleted the xvi-ee branch June 17, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Projection in XVI dump
2 participants