Station name parsing robust #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I recently added the first tests to this repo (see https://github.com/speleo3/inkscape-speleo/tree/master/tests ). There are no tests for |
Yes. I will do it tomorrow. |
|
Hi @rsevero - Any progress with the tests? Can I help you with that? |
|
I am coming back from a cave expedition now.
I will try to take a look at this issue this week.
Regards,
Rodrigo
…-------- Mensagem Original --------
Em 4 de fev. de 2024, 08:49, Thomas Holder escreveu:
Hi ***@***.***(https://github.com/rsevero) - Any progress with the tests? Can I help you with that?
—
Reply to this email directly, [view it on GitHub](#18 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AACM6EBILEFVUYOA6CXTIPTYR5YWPAVCNFSM6AAAAABB4U6Q5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVG4ZDAOBXGU).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
The tests as requested. |
Perfect, thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Station name parsing should be more robust as current code creates stations H8. H9. HA, HB, etc from starting base H8.
It also forces letters capitalization.
These changes fixes both issues amking more complex station names also supported.