Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add terraform files for the getting started tutorial #39

Merged
merged 12 commits into from
Sep 23, 2024
Merged

fix: add terraform files for the getting started tutorial #39

merged 12 commits into from
Sep 23, 2024

Conversation

caroldelwing
Copy link
Contributor

@caroldelwing caroldelwing commented May 31, 2024 •
edited by jira bot
Loading

Describe the Change

This PR includes the following changes:

  • Added Terraform files needed for the new Terraform Getting Started tutorials, which will cover how to deploy and update a cluster to AWS, Azure, GCP, and VMware vSphere.
  • Added Terraform tests
  • Included k9s in the container image
  • Revised grammar in docker.md file
  • Set appuser as the owner of the /home/appuser directory so that the user can create the kubeconfig file required by k9s

Note: this PR will be merged when the tutorials are ready.

Review Changes

🎫 DOC-1200

@caroldelwing caroldelwing added the tutorial Changes related to a tutorial label May 31, 2024
@caroldelwing caroldelwing requested a review from a team as a code owner May 31, 2024 21:15
@caroldelwing caroldelwing requested review from karl-cardenas-coding, addetz and lennessyy and removed request for a team May 31, 2024 21:15
karl-cardenas-coding
karl-cardenas-coding requested changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice start. I left some suggestion below

terraform/getting-started-deployment-tf/clusters.tf Outdated Show resolved Hide resolved
terraform/getting-started-deployment-tf/clusters.tf Outdated Show resolved Hide resolved
terraform/getting-started-deployment-tf/clusters.tf Outdated Show resolved Hide resolved
terraform/getting-started-deployment-tf/clusters.tf Outdated Show resolved Hide resolved
terraform/getting-started-deployment-tf/cluster_profiles.tf Outdated Show resolved Hide resolved
terraform/getting-started-deployment-tf/inputs.tf Outdated Show resolved Hide resolved
terraform/getting-started-deployment-tf/inputs.tf Outdated Show resolved Hide resolved
terraform/getting-started-deployment-tf/ippool.tf Outdated Show resolved Hide resolved
terraform/getting-started-deployment-tf/provider.tf Outdated Show resolved Hide resolved
terraform/getting-started-deployment-tf/ssh-key.tf Show resolved Hide resolved
karl-cardenas-coding
karl-cardenas-coding approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Dockerfile Outdated Show resolved Hide resolved
addetz
addetz approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@addetz addetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful work 👏

@caroldelwing caroldelwing merged commit 77882b1 into main Sep 23, 2024
3 checks passed
@caroldelwing caroldelwing deleted the getting-started-tutorial branch September 23, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addetz addetz addetz approved these changes

@karl-cardenas-coding karl-cardenas-coding karl-cardenas-coding approved these changes

@lennessyy lennessyy Awaiting requested review from lennessyy lennessyy is a code owner automatically assigned from spectrocloud/docs-education

Assignees
No one assigned
Labels
tutorial Changes related to a tutorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caroldelwing @karl-cardenas-coding @addetz