Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add terraform files to deploy a vmware cluster #36

Merged
merged 6 commits into from
Mar 1, 2024
Merged

docs: add terraform files to deploy a vmware cluster #36

merged 6 commits into from
Mar 1, 2024

Conversation

caroldelwing
Copy link
Contributor

@caroldelwing caroldelwing commented Feb 15, 2024 •
edited by jira bot
Loading

Describe the Change

This PR adds the Terraform files required to deploy a VMware cluster profile and cluster. The files will be used in the new PCG tutorial.

(Work in progress, do not merge)

Review Changes

🎫 DOC-1049

@caroldelwing caroldelwing added the tutorial Changes related to a tutorial label Feb 15, 2024
@caroldelwing caroldelwing marked this pull request as ready for review February 20, 2024 14:28
@caroldelwing caroldelwing requested a review from a team as a code owner February 20, 2024 14:28
@caroldelwing caroldelwing requested review from yuliiiah, addetz and lennessyy and removed request for a team February 20, 2024 14:28
karl-cardenas-coding
karl-cardenas-coding requested changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start - I left some suggestions for we can improve the code and user experience. We also need to add an entry to the main README that links to this tutorial README.

terraform/vmware-cluster-deployment-tf/README.md Outdated Show resolved Hide resolved
terraform/vmware-cluster-deployment-tf/README.md Outdated Show resolved Hide resolved
terraform/vmware-cluster-deployment-tf/inputs.tf Outdated Show resolved Hide resolved
terraform/vmware-cluster-deployment-tf/data.tf Outdated Show resolved Hide resolved
terraform/vmware-cluster-deployment-tf/profile.tf Outdated Show resolved Hide resolved
karl-cardenas-coding
karl-cardenas-coding approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

terraform/vmware-cluster-deployment-tf/provider.tf Outdated Show resolved Hide resolved
@caroldelwing caroldelwing merged commit daa33ae into main Mar 1, 2024
3 checks passed
@caroldelwing caroldelwing deleted the pcg-tutorial branch March 1, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karl-cardenas-coding karl-cardenas-coding karl-cardenas-coding approved these changes

@yuliiiah yuliiiah Awaiting requested review from yuliiiah yuliiiah is a code owner automatically assigned from spectrocloud/docs-education

@addetz addetz Awaiting requested review from addetz addetz is a code owner automatically assigned from spectrocloud/docs-education

@lennessyy lennessyy Awaiting requested review from lennessyy lennessyy is a code owner automatically assigned from spectrocloud/docs-education

Assignees
No one assigned
Labels
tutorial Changes related to a tutorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caroldelwing @karl-cardenas-coding