-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLT-1346: Introduce Basic OCI #500
Conversation
So basically registries can be created only and tenant level. and used across the projects. this is handled in resource level itself. not required to update provider.go |
Kindly address the review comments. We will prioritize the changes for testing and include them in the corresponding release. |
For provider_type we can t have required and default. it mutually exclusive. so made it as optional but it will default to 'helm'
Current behavior is below, where
func() resourceRegistryOciEcr
schema handles both ECR and Basic repositories, if needed I can have separation between basic and ecr, but this would require changes to the base resource spectrocloud_registry_oci.Additionally, given that OCI registries exist at a tenant level, would need provider.go to support tenant level actions, like the commented
client.WithScopeTenant()(c)
terraform-provider-spectrocloud/spectrocloud/provider.go
Lines 240 to 242 in d113161