Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLT-701: Added new macros resource support in SDK #85

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Conversation

SivaanandM
Copy link
Contributor

No description provided.

Copy link
Collaborator

@TylerGillson TylerGillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good, but why are you adding another module? this code should all be in macros.go

@SivaanandM
Copy link
Contributor Author

changes look good, but why are you adding another module? this code should all be in macros.go

@TylerGillson We are planning to introduce new macro resources and deprecate the old ones due to inconsistent resource lock issues (Ticket - https://spectrocloud.atlassian.net/browse/PLT-701). For the next couple of releases, both will be supported, and we will deprecate the old resources soon. Hence, we have created separate support for this transition.

client/macros.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@TylerGillson TylerGillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SivaanandM SivaanandM merged commit 2517100 into main Jan 19, 2024
2 checks passed
@SivaanandM SivaanandM deleted the PLT-701 branch January 19, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants