-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 4.4.b - for terrafrom sdk cut over #118
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
018fe2a
Intial sdk cutover push
SivaanandM d4808fe
fix cluster group
SivaanandM 077dde6
fix
SivaanandM 398b391
draft 2
SivaanandM 3bee9e8
fix3
SivaanandM 5a61d3f
updated go mod
SivaanandM aa60d15
removed deprecated edge
SivaanandM 11e6edd
commented swith org
SivaanandM e5a48f1
added comment
SivaanandM cc3798c
corrected the comment
SivaanandM e481c49
PLT-1310: As part of sdk cutover removing libvirt support
SivaanandM 400b312
solving revive issues
SivaanandM 53a39da
revive fix
SivaanandM 9cd712d
refreshed api-go for user info api
SivaanandM 88721e6
fix revive issue
SivaanandM 0cc4feb
fix
SivaanandM dd39703
revive fix2
SivaanandM 6e53090
removed lint issue
SivaanandM 58e3574
PLT-1323: Fixed pause agent upgrades.
SivaanandM c590acd
Merge branch 'main' into release-4.4.b
SivaanandM ca2634e
Merge branch 'main' into release-4.4.b
TylerGillson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious to understand how this function simplifies things on the TF side. You still need to provide a cloud-specific function as a param, so it's not providing anything that's actually generic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll still approve, but I don't see how this is any better than just calling the function you want directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so basically from terraform we are sending cloud specific function as parameter, will simplify it soon