docs: add safeguard against undefined pack versions DOC-1583 #5350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addetz
requested review from
karl-cardenas-coding,
benradstone and
caroldelwing
✅ Deploy Preview for docs-spectrocloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
addetz
added
backport-version-4-0
addetz
force-pushed
the
undefined-version-children-doc-1583
branch
from
fd24786 to
f6751f6
Compare
achuribooks
approved these changes
Jan 10, 2025
codrin-iftimie
approved these changes
Jan 10, 2025
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
* docs: add safeguard against undefined pack versions DOC-1583 * ci: auto-formatting prettier issues * docs: exclude VMO from packs * ci: auto-formatting prettier issues --------- Co-authored-by: addetz <[email protected]> (cherry picked from commit 53300b6)
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
* docs: add safeguard against undefined pack versions DOC-1583 * ci: auto-formatting prettier issues * docs: exclude VMO from packs * ci: auto-formatting prettier issues --------- Co-authored-by: addetz <[email protected]> (cherry picked from commit 53300b6)
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
* docs: add safeguard against undefined pack versions DOC-1583 * ci: auto-formatting prettier issues * docs: exclude VMO from packs * ci: auto-formatting prettier issues --------- Co-authored-by: addetz <[email protected]> (cherry picked from commit 53300b6)
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
* docs: add safeguard against undefined pack versions DOC-1583 * ci: auto-formatting prettier issues * docs: exclude VMO from packs * ci: auto-formatting prettier issues --------- Co-authored-by: addetz <[email protected]> (cherry picked from commit 53300b6)
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
* docs: add safeguard against undefined pack versions DOC-1583 * ci: auto-formatting prettier issues * docs: exclude VMO from packs * ci: auto-formatting prettier issues --------- Co-authored-by: addetz <[email protected]> (cherry picked from commit 53300b6)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
addetz
added a commit
that referenced
this pull request
Jan 10, 2025
* docs: add safeguard against undefined pack versions DOC-1583 * ci: auto-formatting prettier issues * docs: exclude VMO from packs * ci: auto-formatting prettier issues --------- Co-authored-by: addetz <[email protected]>
vault-token-factory-spectrocloud bot
added a commit
that referenced
this pull request
Jan 10, 2025
…5352) * docs: add safeguard against undefined pack versions DOC-1583 * ci: auto-formatting prettier issues * docs: exclude VMO from packs * ci: auto-formatting prettier issues --------- Co-authored-by: addetz <[email protected]> (cherry picked from commit 53300b6) Co-authored-by: Adelina Simion <[email protected]>
vault-token-factory-spectrocloud bot
added a commit
that referenced
this pull request
Jan 10, 2025
…5351) * docs: add safeguard against undefined pack versions DOC-1583 * ci: auto-formatting prettier issues * docs: exclude VMO from packs * ci: auto-formatting prettier issues --------- Co-authored-by: addetz <[email protected]> (cherry picked from commit 53300b6) Co-authored-by: Adelina Simion <[email protected]>
vault-token-factory-spectrocloud bot
added a commit
that referenced
this pull request
Jan 10, 2025
…5353) * docs: add safeguard against undefined pack versions DOC-1583 * ci: auto-formatting prettier issues * docs: exclude VMO from packs * ci: auto-formatting prettier issues --------- Co-authored-by: addetz <[email protected]> (cherry picked from commit 53300b6) Co-authored-by: Adelina Simion <[email protected]>
addetz
added a commit
that referenced
this pull request
Jan 10, 2025
* docs: add safeguard against undefined pack versions DOC-1583 * ci: auto-formatting prettier issues * docs: exclude VMO from packs * ci: auto-formatting prettier issues --------- Co-authored-by: addetz <[email protected]>
vault-token-factory-spectrocloud bot
added a commit
that referenced
this pull request
Jan 10, 2025
…5354) * docs: add safeguard against undefined pack versions DOC-1583 * ci: auto-formatting prettier issues * docs: exclude VMO from packs * ci: auto-formatting prettier issues --------- Co-authored-by: addetz <[email protected]> (cherry picked from commit 53300b6) Co-authored-by: Adelina Simion <[email protected]>
vault-token-factory-spectrocloud bot
added a commit
that referenced
this pull request
Jan 10, 2025
…5355) * docs: add safeguard against undefined pack versions DOC-1583 * ci: auto-formatting prettier issues * docs: exclude VMO from packs * ci: auto-formatting prettier issues --------- Co-authored-by: addetz <[email protected]> (cherry picked from commit 53300b6) Co-authored-by: Adelina Simion <[email protected]>
addetz
added a commit
that referenced
this pull request
Jan 10, 2025
…5356) * docs: add safeguard against undefined pack versions DOC-1583 * ci: auto-formatting prettier issues * docs: exclude VMO from packs * ci: auto-formatting prettier issues --------- Co-authored-by: addetz <[email protected]>
addetz
added a commit
that referenced
this pull request
Jan 10, 2025
…5357) * docs: add safeguard against undefined pack versions DOC-1583 * ci: auto-formatting prettier issues * docs: exclude VMO from packs * ci: auto-formatting prettier issues --------- Co-authored-by: addetz <[email protected]>
|
🎉 This PR is included in version 4.6.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Change
This PR adds a safeguard against undefined children on pack version reading. This was causing outages on the VMO pack. This safeguards makes the code more robust.
Changed Pages
💻 Add Preview URL for Page
Jira Tickets
🎫 DOC-1583
Backports
Can this PR be backported?