Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix tolowercase issue the disable_security_integrations env var #5338

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

caroldelwing
Copy link
Contributor

@caroldelwing caroldelwing commented Jan 9, 2025

Describe the Change

This PR fixes an issue that happens when we execute the make start command when we dont have the DISABLE_SECURITY_INTEGRATIONS variable configured.
image

Changed Pages

💻 Add Preview URL for Page

Jira Tickets

🎫 Jira Ticket

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

@caroldelwing caroldelwing added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 backport-version-4-5 Backport changes to the version-4-5 branch. labels Jan 9, 2025
Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 93aaed1
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/67814d3a1f70ed000824edf4
😎 Deploy Preview https://deploy-preview-5338--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @caroldelwing

@addetz addetz marked this pull request as ready for review January 10, 2025 12:43
@addetz addetz requested a review from a team as a code owner January 10, 2025 12:43
Copy link
Contributor

@addetz addetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see safe code! 👏

@addetz
Copy link
Contributor

addetz commented Jan 10, 2025

Merging this for @caroldelwing as she is on leave 🌴

@addetz addetz merged commit 75135c1 into master Jan 10, 2025
15 checks passed
@addetz addetz deleted the cve-variable-fix branch January 10, 2025 17:32
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jan 10, 2025
…riable (#5338)

Co-authored-by: Karl Cardenas <[email protected]>
(cherry picked from commit 75135c1)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jan 10, 2025
…riable (#5338)

Co-authored-by: Karl Cardenas <[email protected]>
(cherry picked from commit 75135c1)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jan 10, 2025
…riable (#5338)

Co-authored-by: Karl Cardenas <[email protected]>
(cherry picked from commit 75135c1)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jan 10, 2025
…riable (#5338)

Co-authored-by: Karl Cardenas <[email protected]>
(cherry picked from commit 75135c1)
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
version-4-0
version-3-4
version-4-1
version-4-2
version-4-3
version-4-4
version-4-5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jan 10, 2025
…riable (#5338) (#5359)

Co-authored-by: Karl Cardenas <[email protected]>
(cherry picked from commit 75135c1)

Co-authored-by: caroldelwing <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jan 10, 2025
…riable (#5338) (#5360)

Co-authored-by: Karl Cardenas <[email protected]>
(cherry picked from commit 75135c1)

Co-authored-by: caroldelwing <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jan 10, 2025
…riable (#5338) (#5358)

Co-authored-by: Karl Cardenas <[email protected]>
(cherry picked from commit 75135c1)

Co-authored-by: caroldelwing <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jan 10, 2025
…riable (#5338) (#5363)

Co-authored-by: Karl Cardenas <[email protected]>
(cherry picked from commit 75135c1)

Co-authored-by: caroldelwing <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jan 10, 2025
…riable (#5338) (#5362)

Co-authored-by: Karl Cardenas <[email protected]>
(cherry picked from commit 75135c1)

Co-authored-by: caroldelwing <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jan 10, 2025
…riable (#5338) (#5361)

Co-authored-by: Karl Cardenas <[email protected]>
(cherry picked from commit 75135c1)

Co-authored-by: caroldelwing <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jan 10, 2025
…riable (#5338) (#5364)

Co-authored-by: Karl Cardenas <[email protected]>
(cherry picked from commit 75135c1)

Co-authored-by: caroldelwing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 backport-version-4-5 Backport changes to the version-4-5 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants