Azure Permissions Refactor #4272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karl-cardenas-coding
added
backport-version-4-0
✅ Deploy Preview for docs-spectrocloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mattwelke
requested changes
Oct 15, 2024
docs/docs-content/clusters/public-cloud/azure/required-permissions.md
Outdated
Show resolved
Hide resolved
docs/docs-content/clusters/public-cloud/azure/required-permissions.md
Outdated
Show resolved
Hide resolved
docs/docs-content/clusters/public-cloud/azure/required-permissions.md
Outdated
Show resolved
Hide resolved
docs/docs-content/clusters/public-cloud/azure/required-permissions.md
Outdated
Show resolved
Hide resolved
docs/docs-content/clusters/public-cloud/azure/required-permissions.md
Outdated
Show resolved
Hide resolved
mattwelke
requested changes
Oct 22, 2024
There was a problem hiding this comment.
Overall, new docs look great! I like how we break things down by deployment type for each of the four types.
I left some comments about things we should omit and some fixes for the --scope part of some role assignment create commands. I believe the reason the scopes in those commands were incorrect was because you had mixed up the concepts of "assignable scopes" and "scope" (while assigning). Feel free to ping me if you'd like me to explain more about that.
docs/docs-content/clusters/public-cloud/azure/required-permissions.md
Outdated
Show resolved
Hide resolved
docs/docs-content/clusters/public-cloud/azure/required-permissions.md
Outdated
Show resolved
Hide resolved
docs/docs-content/clusters/public-cloud/azure/required-permissions.md
Outdated
Show resolved
Hide resolved
docs/docs-content/clusters/public-cloud/azure/required-permissions.md
Outdated
Show resolved
Hide resolved
docs/docs-content/clusters/public-cloud/azure/required-permissions.md
Outdated
Show resolved
Hide resolved
docs/docs-content/clusters/public-cloud/azure/required-permissions.md
Outdated
Show resolved
Hide resolved
docs/docs-content/clusters/public-cloud/azure/required-permissions.md
Outdated
Show resolved
Hide resolved
docs/docs-content/clusters/public-cloud/azure/required-permissions.md
Outdated
Show resolved
Hide resolved
docs/docs-content/clusters/public-cloud/azure/required-permissions.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Matt Welke <[email protected]>
mattwelke
requested changes
Oct 29, 2024
docs/docs-content/clusters/public-cloud/azure/required-permissions.md
Outdated
Show resolved
Hide resolved
kreeuwijk
reviewed
Oct 29, 2024
kreeuwijk
reviewed
Oct 29, 2024
kreeuwijk
reviewed
Oct 29, 2024
kreeuwijk
reviewed
Oct 29, 2024
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
* docs: DOC-928 DOC-929 DOC-930 DOC-931 DOC-927 * docs: static IaaS * docs: iaas dynamic * chore: fix headings * docs: aks static placement * docs: aks dynamic placement * docs: vale suggestions * docs: apply suggestions from code review Co-authored-by: Matt Welke <[email protected]> * docs: applied feedback * docs: feedback * docs: feedback * docs: upadated IAM policies * chore: updated warning * docs: apply suggestions from code review Co-authored-by: Lenny Chen <[email protected]> --------- Co-authored-by: Matt Welke <[email protected]> Co-authored-by: Lenny Chen <[email protected]> (cherry picked from commit d616a10)
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
* docs: DOC-928 DOC-929 DOC-930 DOC-931 DOC-927 * docs: static IaaS * docs: iaas dynamic * chore: fix headings * docs: aks static placement * docs: aks dynamic placement * docs: vale suggestions * docs: apply suggestions from code review Co-authored-by: Matt Welke <[email protected]> * docs: applied feedback * docs: feedback * docs: feedback * docs: upadated IAM policies * chore: updated warning * docs: apply suggestions from code review Co-authored-by: Lenny Chen <[email protected]> --------- Co-authored-by: Matt Welke <[email protected]> Co-authored-by: Lenny Chen <[email protected]> (cherry picked from commit d616a10)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
karl-cardenas-coding
added a commit
that referenced
this pull request
Oct 30, 2024
* docs: DOC-928 DOC-929 DOC-930 DOC-931 DOC-927 * docs: static IaaS * docs: iaas dynamic * chore: fix headings * docs: aks static placement * docs: aks dynamic placement * docs: vale suggestions * docs: apply suggestions from code review Co-authored-by: Matt Welke <[email protected]> * docs: applied feedback * docs: feedback * docs: feedback * docs: upadated IAM policies * chore: updated warning * docs: apply suggestions from code review Co-authored-by: Lenny Chen <[email protected]> --------- Co-authored-by: Matt Welke <[email protected]> Co-authored-by: Lenny Chen <[email protected]>
karl-cardenas-coding
added a commit
that referenced
this pull request
Oct 30, 2024
* docs: DOC-928 DOC-929 DOC-930 DOC-931 DOC-927 * docs: static IaaS * docs: iaas dynamic * chore: fix headings * docs: aks static placement * docs: aks dynamic placement * docs: vale suggestions * docs: apply suggestions from code review Co-authored-by: Matt Welke <[email protected]> * docs: applied feedback * docs: feedback * docs: feedback * docs: upadated IAM policies * chore: updated warning * docs: apply suggestions from code review Co-authored-by: Lenny Chen <[email protected]> --------- Co-authored-by: Matt Welke <[email protected]> Co-authored-by: Lenny Chen <[email protected]>
karl-cardenas-coding
added a commit
that referenced
this pull request
Oct 30, 2024
* docs: DOC-928 DOC-929 DOC-930 DOC-931 DOC-927 * docs: static IaaS * docs: iaas dynamic * chore: fix headings * docs: aks static placement * docs: aks dynamic placement * docs: vale suggestions * docs: apply suggestions from code review Co-authored-by: Matt Welke <[email protected]> * docs: applied feedback * docs: feedback * docs: feedback * docs: upadated IAM policies * chore: updated warning * docs: apply suggestions from code review Co-authored-by: Lenny Chen <[email protected]> --------- Co-authored-by: Matt Welke <[email protected]> Co-authored-by: Lenny Chen <[email protected]>
karl-cardenas-coding
added a commit
that referenced
this pull request
Oct 30, 2024
* docs: DOC-928 DOC-929 DOC-930 DOC-931 DOC-927 * docs: static IaaS * docs: iaas dynamic * chore: fix headings * docs: aks static placement * docs: aks dynamic placement * docs: vale suggestions * docs: apply suggestions from code review Co-authored-by: Matt Welke <[email protected]> * docs: applied feedback * docs: feedback * docs: feedback * docs: upadated IAM policies * chore: updated warning * docs: apply suggestions from code review Co-authored-by: Lenny Chen <[email protected]> --------- Co-authored-by: Matt Welke <[email protected]> Co-authored-by: Lenny Chen <[email protected]>
vault-token-factory-spectrocloud bot
added a commit
that referenced
this pull request
Oct 30, 2024
* docs: DOC-928 DOC-929 DOC-930 DOC-931 DOC-927 * docs: static IaaS * docs: iaas dynamic * chore: fix headings * docs: aks static placement * docs: aks dynamic placement * docs: vale suggestions * docs: apply suggestions from code review Co-authored-by: Matt Welke <[email protected]> * docs: applied feedback * docs: feedback * docs: feedback * docs: upadated IAM policies * chore: updated warning * docs: apply suggestions from code review Co-authored-by: Lenny Chen <[email protected]> --------- Co-authored-by: Matt Welke <[email protected]> Co-authored-by: Lenny Chen <[email protected]> (cherry picked from commit d616a10) Co-authored-by: Karl Cardenas <[email protected]>
vault-token-factory-spectrocloud bot
added a commit
that referenced
this pull request
Oct 30, 2024
* docs: DOC-928 DOC-929 DOC-930 DOC-931 DOC-927 * docs: static IaaS * docs: iaas dynamic * chore: fix headings * docs: aks static placement * docs: aks dynamic placement * docs: vale suggestions * docs: apply suggestions from code review Co-authored-by: Matt Welke <[email protected]> * docs: applied feedback * docs: feedback * docs: feedback * docs: upadated IAM policies * chore: updated warning * docs: apply suggestions from code review Co-authored-by: Lenny Chen <[email protected]> --------- Co-authored-by: Matt Welke <[email protected]> Co-authored-by: Lenny Chen <[email protected]> (cherry picked from commit d616a10) Co-authored-by: Karl Cardenas <[email protected]>
karl-cardenas-coding
added a commit
that referenced
this pull request
Oct 30, 2024
* docs: DOC-928 DOC-929 DOC-930 DOC-931 DOC-927 * docs: static IaaS * docs: iaas dynamic * chore: fix headings * docs: aks static placement * docs: aks dynamic placement * docs: vale suggestions * docs: apply suggestions from code review Co-authored-by: Matt Welke <[email protected]> * docs: applied feedback * docs: feedback * docs: feedback * docs: upadated IAM policies * chore: updated warning * docs: apply suggestions from code review Co-authored-by: Lenny Chen <[email protected]> --------- Co-authored-by: Matt Welke <[email protected]> Co-authored-by: Lenny Chen <[email protected]>
karl-cardenas-coding
added a commit
that referenced
this pull request
Oct 30, 2024
* docs: DOC-928 DOC-929 DOC-930 DOC-931 DOC-927 * docs: static IaaS * docs: iaas dynamic * chore: fix headings * docs: aks static placement * docs: aks dynamic placement * docs: vale suggestions * docs: apply suggestions from code review * docs: applied feedback * docs: feedback * docs: feedback * docs: upadated IAM policies * chore: updated warning * docs: apply suggestions from code review --------- Co-authored-by: Matt Welke <[email protected]> Co-authored-by: Lenny Chen <[email protected]>
karl-cardenas-coding
added a commit
that referenced
this pull request
Oct 30, 2024
* docs: DOC-928 DOC-929 DOC-930 DOC-931 DOC-927 * docs: static IaaS * docs: iaas dynamic * chore: fix headings * docs: aks static placement * docs: aks dynamic placement * docs: vale suggestions * docs: apply suggestions from code review Co-authored-by: Matt Welke <[email protected]> * docs: applied feedback * docs: feedback * docs: feedback * docs: upadated IAM policies * chore: updated warning * docs: apply suggestions from code review Co-authored-by: Lenny Chen <[email protected]> --------- Co-authored-by: Matt Welke <[email protected]> Co-authored-by: Lenny Chen <[email protected]>
karl-cardenas-coding
added a commit
that referenced
this pull request
Oct 30, 2024
* docs: DOC-928 DOC-929 DOC-930 DOC-931 DOC-927 * docs: static IaaS * docs: iaas dynamic * chore: fix headings * docs: aks static placement * docs: aks dynamic placement * docs: vale suggestions * docs: apply suggestions from code review * docs: applied feedback * docs: feedback * docs: feedback * docs: upadated IAM policies * chore: updated warning * docs: apply suggestions from code review --------- Co-authored-by: Matt Welke <[email protected]> Co-authored-by: Lenny Chen <[email protected]>
karl-cardenas-coding
added a commit
that referenced
this pull request
Oct 30, 2024
* docs: DOC-928 DOC-929 DOC-930 DOC-931 DOC-927 * docs: static IaaS * docs: iaas dynamic * chore: fix headings * docs: aks static placement * docs: aks dynamic placement * docs: vale suggestions * docs: apply suggestions from code review * docs: applied feedback * docs: feedback * docs: feedback * docs: upadated IAM policies * chore: updated warning * docs: apply suggestions from code review --------- Co-authored-by: Matt Welke <[email protected]> Co-authored-by: Lenny Chen <[email protected]>
karl-cardenas-coding
added a commit
that referenced
this pull request
Oct 30, 2024
* docs: DOC-928 DOC-929 DOC-930 DOC-931 DOC-927 * docs: static IaaS * docs: iaas dynamic * chore: fix headings * docs: aks static placement * docs: aks dynamic placement * docs: vale suggestions * docs: apply suggestions from code review * docs: applied feedback * docs: feedback * docs: feedback * docs: upadated IAM policies * chore: updated warning * docs: apply suggestions from code review --------- Co-authored-by: Matt Welke <[email protected]> Co-authored-by: Lenny Chen <[email protected]>
karl-cardenas-coding
added a commit
that referenced
this pull request
Oct 30, 2024
* docs: DOC-928 DOC-929 DOC-930 DOC-931 DOC-927 * docs: static IaaS * docs: iaas dynamic * chore: fix headings * docs: aks static placement * docs: aks dynamic placement * docs: vale suggestions * docs: apply suggestions from code review * docs: applied feedback * docs: feedback * docs: feedback * docs: upadated IAM policies * chore: updated warning * docs: apply suggestions from code review --------- Co-authored-by: Matt Welke <[email protected]> Co-authored-by: Lenny Chen <[email protected]>
|
🎉 This issue has been resolved in version 4.5.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Change
This PR refactors the current Azure permissions page. Dedicated sections for IaaS and AKS are now available. Within each use case, static and dynamic scenario permissions are shared.
Additionally, AWS IAM Permissions were updated. The four main policies are now defined as core policies. The Minimum permissions received the Deployment Policy permissions as they are required.
Changed Pages
💻 Azure Permissions Preview URL for Page
💻 AWS Permissions Preview URL for Page
Jira Tickets
🎫 DOC-928
🎫 DOC-929
🎫 DOC-930
🎫 DOC-931
Backports
Can this PR be backported?