-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: refactor taints guide DOC-1272 #3395
Conversation
✅ Deploy Preview for docs-spectrocloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 75.6%, saving 1.18 MB.
711 images did not require optimisation. |
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 1.8%, saving 5.65 KB.
712 images did not require optimisation. |
e651aea
to
b022c6b
Compare
b022c6b
to
84fc1b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes. I left some minor suggestions below 🚀
Co-authored-by: Karl Cardenas <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
e47ea7c
to
b33e246
Compare
* docs: refactor taints guide DOC-1272 * docs: add node labels guide DOC-1272 * docs: fix vale DOC-1272 * Optimised images with calibre/image-actions * Optimised images with calibre/image-actions * docs: fix broken anchors DOC-1272 * docs: adjust wording on new pages DOC-1272 * docs:fix formatting DOC-1272 * Apply suggestions from code review Co-authored-by: Karl Cardenas <[email protected]> * Apply suggestions from code review Co-authored-by: Karl Cardenas <[email protected]> * docs: fix indentation of pages DOC-1272 * docs: tweak intro to compare node labels and taints DOC-1272 * docs: fix vale DOC-1272 * docs: fix formatting DOC-1272 --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com> Co-authored-by: Karl Cardenas <[email protected]> (cherry picked from commit 7ae0c53)
* docs: refactor taints guide DOC-1272 * docs: add node labels guide DOC-1272 * docs: fix vale DOC-1272 * Optimised images with calibre/image-actions * Optimised images with calibre/image-actions * docs: fix broken anchors DOC-1272 * docs: adjust wording on new pages DOC-1272 * docs:fix formatting DOC-1272 * Apply suggestions from code review Co-authored-by: Karl Cardenas <[email protected]> * Apply suggestions from code review Co-authored-by: Karl Cardenas <[email protected]> * docs: fix indentation of pages DOC-1272 * docs: tweak intro to compare node labels and taints DOC-1272 * docs: fix vale DOC-1272 * docs: fix formatting DOC-1272 --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com> Co-authored-by: Karl Cardenas <[email protected]> (cherry picked from commit 7ae0c53)
💔 Some backports could not be createdNote: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
* docs: refactor taints guide DOC-1272 * docs: add node labels guide DOC-1272 * docs: fix vale DOC-1272 * Optimised images with calibre/image-actions * Optimised images with calibre/image-actions * docs: fix broken anchors DOC-1272 * docs: adjust wording on new pages DOC-1272 * docs:fix formatting DOC-1272 * Apply suggestions from code review Co-authored-by: Karl Cardenas <[email protected]> * Apply suggestions from code review Co-authored-by: Karl Cardenas <[email protected]> * docs: fix indentation of pages DOC-1272 * docs: tweak intro to compare node labels and taints DOC-1272 * docs: fix vale DOC-1272 * docs: fix formatting DOC-1272 --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com> Co-authored-by: Karl Cardenas <[email protected]> (cherry picked from commit 7ae0c53) Co-authored-by: Adelina Simion <[email protected]>
* docs: refactor taints guide DOC-1272 * docs: add node labels guide DOC-1272 * docs: fix vale DOC-1272 * Optimised images with calibre/image-actions * Optimised images with calibre/image-actions * docs: fix broken anchors DOC-1272 * docs: adjust wording on new pages DOC-1272 * docs:fix formatting DOC-1272 * Apply suggestions from code review Co-authored-by: Karl Cardenas <[email protected]> * Apply suggestions from code review Co-authored-by: Karl Cardenas <[email protected]> * docs: fix indentation of pages DOC-1272 * docs: tweak intro to compare node labels and taints DOC-1272 * docs: fix vale DOC-1272 * docs: fix formatting DOC-1272 --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com> Co-authored-by: Karl Cardenas <[email protected]> (cherry picked from commit 7ae0c53) Co-authored-by: Adelina Simion <[email protected]>
* docs: refactor taints guide DOC-1272 * docs: add node labels guide DOC-1272 * docs: fix vale DOC-1272 * Optimised images with calibre/image-actions * Optimised images with calibre/image-actions * docs: fix broken anchors DOC-1272 * docs: adjust wording on new pages DOC-1272 * docs:fix formatting DOC-1272 * Apply suggestions from code review Co-authored-by: Karl Cardenas <[email protected]> * Apply suggestions from code review Co-authored-by: Karl Cardenas <[email protected]> * docs: fix indentation of pages DOC-1272 * docs: tweak intro to compare node labels and taints DOC-1272 * docs: fix vale DOC-1272 * docs: fix formatting DOC-1272 --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com> Co-authored-by: Karl Cardenas <[email protected]>
* docs: refactor taints guide DOC-1272 * docs: add node labels guide DOC-1272 * docs: fix vale DOC-1272 * Optimised images with calibre/image-actions * Optimised images with calibre/image-actions * docs: fix broken anchors DOC-1272 * docs: adjust wording on new pages DOC-1272 * docs:fix formatting DOC-1272 * Apply suggestions from code review Co-authored-by: Karl Cardenas <[email protected]> * Apply suggestions from code review Co-authored-by: Karl Cardenas <[email protected]> * docs: fix indentation of pages DOC-1272 * docs: tweak intro to compare node labels and taints DOC-1272 * docs: fix vale DOC-1272 * docs: fix formatting DOC-1272 --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com> Co-authored-by: Karl Cardenas <[email protected]>
* docs: refactor taints guide DOC-1272 * docs: add node labels guide DOC-1272 * docs: fix vale DOC-1272 * Optimised images with calibre/image-actions * Optimised images with calibre/image-actions * docs: fix broken anchors DOC-1272 * docs: adjust wording on new pages DOC-1272 * docs:fix formatting DOC-1272 * Apply suggestions from code review Co-authored-by: Karl Cardenas <[email protected]> * Apply suggestions from code review Co-authored-by: Karl Cardenas <[email protected]> * docs: fix indentation of pages DOC-1272 * docs: tweak intro to compare node labels and taints DOC-1272 * docs: fix vale DOC-1272 * docs: fix formatting DOC-1272 --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com> Co-authored-by: Karl Cardenas <[email protected]>
* docs: refactor taints guide DOC-1272 * docs: add node labels guide DOC-1272 * docs: fix vale DOC-1272 * Optimised images with calibre/image-actions * Optimised images with calibre/image-actions * docs: fix broken anchors DOC-1272 * docs: adjust wording on new pages DOC-1272 * docs:fix formatting DOC-1272 * Apply suggestions from code review Co-authored-by: Karl Cardenas <[email protected]> * Apply suggestions from code review Co-authored-by: Karl Cardenas <[email protected]> * docs: fix indentation of pages DOC-1272 * docs: tweak intro to compare node labels and taints DOC-1272 * docs: fix vale DOC-1272 * docs: fix formatting DOC-1272 --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com> Co-authored-by: Karl Cardenas <[email protected]>
* docs: refactor taints guide DOC-1272 * docs: add node labels guide DOC-1272 * docs: fix vale DOC-1272 * Optimised images with calibre/image-actions * Optimised images with calibre/image-actions * docs: fix broken anchors DOC-1272 * docs: adjust wording on new pages DOC-1272 * docs:fix formatting DOC-1272 * Apply suggestions from code review * Apply suggestions from code review * docs: fix indentation of pages DOC-1272 * docs: tweak intro to compare node labels and taints DOC-1272 * docs: fix vale DOC-1272 * docs: fix formatting DOC-1272 --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com> Co-authored-by: Karl Cardenas <[email protected]>
* docs: refactor taints guide DOC-1272 (#3395) * docs: refactor taints guide DOC-1272 * docs: add node labels guide DOC-1272 * docs: fix vale DOC-1272 * Optimised images with calibre/image-actions * Optimised images with calibre/image-actions * docs: fix broken anchors DOC-1272 * docs: adjust wording on new pages DOC-1272 * docs:fix formatting DOC-1272 * Apply suggestions from code review Co-authored-by: Karl Cardenas <[email protected]> * Apply suggestions from code review Co-authored-by: Karl Cardenas <[email protected]> * docs: fix indentation of pages DOC-1272 * docs: tweak intro to compare node labels and taints DOC-1272 * docs: fix vale DOC-1272 * docs: fix formatting DOC-1272 --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com> Co-authored-by: Karl Cardenas <[email protected]> * docs: revert api.json --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com> Co-authored-by: Karl Cardenas <[email protected]>
* docs: refactor taints guide DOC-1272 (#3395) * docs: refactor taints guide DOC-1272 * docs: add node labels guide DOC-1272 * docs: fix vale DOC-1272 * Optimised images with calibre/image-actions * Optimised images with calibre/image-actions * docs: fix broken anchors DOC-1272 * docs: adjust wording on new pages DOC-1272 * docs:fix formatting DOC-1272 * Apply suggestions from code review Co-authored-by: Karl Cardenas <[email protected]> * Apply suggestions from code review Co-authored-by: Karl Cardenas <[email protected]> * docs: fix indentation of pages DOC-1272 * docs: tweak intro to compare node labels and taints DOC-1272 * docs: fix vale DOC-1272 * docs: fix formatting DOC-1272 --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com> Co-authored-by: Karl Cardenas <[email protected]> * docs: fix formatting --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com> Co-authored-by: Karl Cardenas <[email protected]>
* docs: refactor taints guide DOC-1272 (#3395) * docs: refactor taints guide DOC-1272 * docs: add node labels guide DOC-1272 * docs: fix vale DOC-1272 * Optimised images with calibre/image-actions * Optimised images with calibre/image-actions * docs: fix broken anchors DOC-1272 * docs: adjust wording on new pages DOC-1272 * docs:fix formatting DOC-1272 * Apply suggestions from code review Co-authored-by: Karl Cardenas <[email protected]> * Apply suggestions from code review Co-authored-by: Karl Cardenas <[email protected]> * docs: fix indentation of pages DOC-1272 * docs: tweak intro to compare node labels and taints DOC-1272 * docs: fix vale DOC-1272 * docs: fix formatting DOC-1272 --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com> Co-authored-by: Karl Cardenas <[email protected]> * docs: fix broken links in new pages * docs: fix additional broken links --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com> Co-authored-by: Karl Cardenas <[email protected]>
Describe the Change
This PR refactors the Node Labels and Taints page by splitting it up into two separate pages, one for Taints and one for Node Labels. Both pages use the How-To layout.
Changed Pages
💻 Node Labels
💻 Taints and Tolerations
Jira Tickets
🎫 DOC-1272
Backports
Can this PR be backported?