Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra capabilities #2354

Merged
merged 26 commits into from
Mar 25, 2024
Merged

Extra capabilities #2354

merged 26 commits into from
Mar 25, 2024

Conversation

caroldelwing
Copy link
Contributor

@caroldelwing caroldelwing commented Mar 5, 2024

Describe the Change

This PR adds a "Palette Additional Capabilities" page to the new Getting Started section as outlined in Approach 2 of the Revise and Link Existing Content RFC.

Review Changes

💻 Getting Started
💻 Palette Additional Capabilities

🎫 DOC-1066

Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 9b98bee
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/6601e9092caf6000084b46f6
😎 Deploy Preview https://deploy-preview-2354--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@caroldelwing caroldelwing marked this pull request as ready for review March 5, 2024 22:32
@caroldelwing caroldelwing requested a review from a team as a code owner March 5, 2024 22:32
@caroldelwing caroldelwing added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 labels Mar 5, 2024
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Images automagically compressed by Calibre's image-actions

Compression reduced images by 28.2%, saving 418.80 KB.

Filename Before After Improvement Visual comparison
static/assets/docs/images/getting-started/getting-started_additional-capabilities_palette.png 1.45 MB 1.04 MB -28.2% View diff

661 images did not require optimisation.

Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @caroldelwing really good start but we have some opprtuntieis for improvement. Take a peek at the feedback below. Additionaly, touch base with the following PMs for each respective section:

  • Edge - Anton
  • VerteX - Tom
  • VMO - Romain

I can work with you on self-hosted.

Copy link
Contributor

github-actions bot commented Mar 8, 2024

Images automagically compressed by Calibre's image-actions

Compression reduced images by 28.2%, saving 428.25 KB.

Filename Before After Improvement Visual comparison
static/assets/docs/images/getting-started/getting-started_additional-capabilities_palette.png 1.48 MB 1.06 MB -28.2% View diff

661 images did not require optimisation.

Copy link
Contributor

@antongisli antongisli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finished my review. I think this document might benefit from a quick reveiw from Mr Ant Newman also.

@vault-token-factory-spectrocloud
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 92%, saving 1,002.55 KB.

Filename Before After Improvement Visual comparison
static/assets/docs/images/getting-started/getting-started_additional-capabilities_palette.webp 1.06 MB 86.79 KB -92.0% View diff

665 images did not require optimisation.

@vault-token-factory-spectrocloud
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 4.1%, saving 3.53 KB.

Filename Before After Improvement Visual comparison
static/assets/docs/images/getting-started/getting-started_additional-capabilities_palette.webp 86.79 KB 83.27 KB -4.1% View diff

665 images did not require optimisation.

@vault-token-factory-spectrocloud
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 1.4%, saving 1.19 KB.

Filename Before After Improvement Visual comparison
static/assets/docs/images/getting-started/getting-started_additional-capabilities_palette.webp 83.27 KB 82.07 KB -1.4% View diff

665 images did not require optimisation.

@caroldelwing caroldelwing merged commit 50c46ec into master Mar 25, 2024
12 checks passed
@caroldelwing caroldelwing deleted the extra-capabilities branch March 25, 2024 21:39
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Mar 25, 2024
* docs: first draft of the page

* docs: address review suggestions

* docs: replace images, add links

* docs: vale suggestions, remove images

* Optimised images with calibre/image-actions

* Apply suggestions from code review

Co-authored-by: Karl Cardenas <[email protected]>

* docs: address suggestions from review

* Optimised images with calibre/image-actions

* docs: address review suggestions

* docs: address review suggestions

* docs: add cloud links

* docs: address suggestions - vertex

* docs: remove Palette from the title

* docs: address mkt suggestions

* docs: vale feedback

* Optimised images with calibre/image-actions

* Optimised images with calibre/image-actions

* Optimised images with calibre/image-actions

* docs: fix image title

* docs: fix broken link

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Karl Cardenas <[email protected]>
Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com>
(cherry picked from commit 50c46ec)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Mar 25, 2024
* docs: first draft of the page

* docs: address review suggestions

* docs: replace images, add links

* docs: vale suggestions, remove images

* Optimised images with calibre/image-actions

* Apply suggestions from code review

Co-authored-by: Karl Cardenas <[email protected]>

* docs: address suggestions from review

* Optimised images with calibre/image-actions

* docs: address review suggestions

* docs: address review suggestions

* docs: add cloud links

* docs: address suggestions - vertex

* docs: remove Palette from the title

* docs: address mkt suggestions

* docs: vale feedback

* Optimised images with calibre/image-actions

* Optimised images with calibre/image-actions

* Optimised images with calibre/image-actions

* docs: fix image title

* docs: fix broken link

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Karl Cardenas <[email protected]>
Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com>
(cherry picked from commit 50c46ec)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Mar 25, 2024
* docs: first draft of the page

* docs: address review suggestions

* docs: replace images, add links

* docs: vale suggestions, remove images

* Optimised images with calibre/image-actions

* Apply suggestions from code review

Co-authored-by: Karl Cardenas <[email protected]>

* docs: address suggestions from review

* Optimised images with calibre/image-actions

* docs: address review suggestions

* docs: address review suggestions

* docs: add cloud links

* docs: address suggestions - vertex

* docs: remove Palette from the title

* docs: address mkt suggestions

* docs: vale feedback

* Optimised images with calibre/image-actions

* Optimised images with calibre/image-actions

* Optimised images with calibre/image-actions

* docs: fix image title

* docs: fix broken link

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Karl Cardenas <[email protected]>
Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com>
(cherry picked from commit 50c46ec)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Mar 25, 2024
* docs: first draft of the page

* docs: address review suggestions

* docs: replace images, add links

* docs: vale suggestions, remove images

* Optimised images with calibre/image-actions

* Apply suggestions from code review

Co-authored-by: Karl Cardenas <[email protected]>

* docs: address suggestions from review

* Optimised images with calibre/image-actions

* docs: address review suggestions

* docs: address review suggestions

* docs: add cloud links

* docs: address suggestions - vertex

* docs: remove Palette from the title

* docs: address mkt suggestions

* docs: vale feedback

* Optimised images with calibre/image-actions

* Optimised images with calibre/image-actions

* Optimised images with calibre/image-actions

* docs: fix image title

* docs: fix broken link

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Karl Cardenas <[email protected]>
Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com>
(cherry picked from commit 50c46ec)
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
version-4-0
version-3-4
version-4-1
version-4-2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud bot added a commit that referenced this pull request Mar 25, 2024
* docs: first draft of the page

* docs: address review suggestions

* docs: replace images, add links

* docs: vale suggestions, remove images

* Optimised images with calibre/image-actions

* Apply suggestions from code review

Co-authored-by: Karl Cardenas <[email protected]>

* docs: address suggestions from review

* Optimised images with calibre/image-actions

* docs: address review suggestions

* docs: address review suggestions

* docs: add cloud links

* docs: address suggestions - vertex

* docs: remove Palette from the title

* docs: address mkt suggestions

* docs: vale feedback

* Optimised images with calibre/image-actions

* Optimised images with calibre/image-actions

* Optimised images with calibre/image-actions

* docs: fix image title

* docs: fix broken link

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Karl Cardenas <[email protected]>
Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com>
(cherry picked from commit 50c46ec)

Co-authored-by: caroldelwing <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Mar 25, 2024
* docs: first draft of the page

* docs: address review suggestions

* docs: replace images, add links

* docs: vale suggestions, remove images

* Optimised images with calibre/image-actions

* Apply suggestions from code review

Co-authored-by: Karl Cardenas <[email protected]>

* docs: address suggestions from review

* Optimised images with calibre/image-actions

* docs: address review suggestions

* docs: address review suggestions

* docs: add cloud links

* docs: address suggestions - vertex

* docs: remove Palette from the title

* docs: address mkt suggestions

* docs: vale feedback

* Optimised images with calibre/image-actions

* Optimised images with calibre/image-actions

* Optimised images with calibre/image-actions

* docs: fix image title

* docs: fix broken link

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Karl Cardenas <[email protected]>
Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com>
(cherry picked from commit 50c46ec)

Co-authored-by: caroldelwing <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Mar 25, 2024
* docs: first draft of the page

* docs: address review suggestions

* docs: replace images, add links

* docs: vale suggestions, remove images

* Optimised images with calibre/image-actions

* Apply suggestions from code review

Co-authored-by: Karl Cardenas <[email protected]>

* docs: address suggestions from review

* Optimised images with calibre/image-actions

* docs: address review suggestions

* docs: address review suggestions

* docs: add cloud links

* docs: address suggestions - vertex

* docs: remove Palette from the title

* docs: address mkt suggestions

* docs: vale feedback

* Optimised images with calibre/image-actions

* Optimised images with calibre/image-actions

* Optimised images with calibre/image-actions

* docs: fix image title

* docs: fix broken link

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Karl Cardenas <[email protected]>
Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com>
(cherry picked from commit 50c46ec)

Co-authored-by: caroldelwing <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Mar 26, 2024
* Extra capabilities (#2354)

* docs: first draft of the page

* docs: address review suggestions

* docs: replace images, add links

* docs: vale suggestions, remove images

* Optimised images with calibre/image-actions

* Apply suggestions from code review

Co-authored-by: Karl Cardenas <[email protected]>

* docs: address suggestions from review

* Optimised images with calibre/image-actions

* docs: address review suggestions

* docs: address review suggestions

* docs: add cloud links

* docs: address suggestions - vertex

* docs: remove Palette from the title

* docs: address mkt suggestions

* docs: vale feedback

* Optimised images with calibre/image-actions

* Optimised images with calibre/image-actions

* Optimised images with calibre/image-actions

* docs: fix image title

* docs: fix broken link

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Karl Cardenas <[email protected]>
Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com>
(cherry picked from commit 50c46ec)

* docs: remove vertex as it was introduced in v4.0

---------

Co-authored-by: caroldelwing <[email protected]>
@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This PR is included in version 4.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This PR is included in version 4.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants